Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAINTROID-421 - Option to enlarge canvas when using the "Import image" tool #1332

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

PAINTROID-421 - Option to enlarge canvas when using the "Import image" tool #1332

wants to merge 1 commit into from

Conversation

JulianJautz
Copy link
Contributor

@JulianJautz JulianJautz commented Feb 12, 2024 •
edited
Loading

showing dialog to enlarge canvas when imported image is larger than canvas
(or at least one part of the image is outside of the canvas)

  • dialog is not shown if image is not outside of the border
  • if enlarging image would set canvas larger than max canvas size another dialog with this info will show
  • works also when switching to another tool without clicking the checkmark

https://catrobat.atlassian.net/browse/PAINTROID-421

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

PAINTROID_421_enlarge_canvas_import_tool
1984718 
showing dialog to enlarge when import is larger than canvas

- shown only if image is outside of canvas border
- second dialog shown, maximum bitmap size would be exceeded
@JulianJautz JulianJautz force-pushed the PAINTROID-421_enlarge_canvas_import_tool branch from 266398a to 1984718 Compare March 20, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JulianJautz