Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds multiplayer functionality to PCL.Mac using the SwiftScaffolding library (version 0.1.1) and implements the Scaffolding protocol for interoperability with other Minecraft launchers like HMCL. The implementation is based on EasyTier for peer-to-peer networking.
Changes:
- Added multiplayer functionality with room creation and joining capabilities
- Integrated SwiftScaffolding library and EasyTier networking
- Added MessageBoxManager for UI dialogs and EasyTierManager for EasyTier lifecycle management
- Included license files for new dependencies (SwiftScaffolding, SwiftyJSON, ZIPFoundation, EasyTier)
Reviewed changes
Copilot reviewed 21 out of 26 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| Resources/licenses/*.LICENSE.txt | License files for new dependencies (SwiftScaffolding, SwiftyJSON, ZIPFoundation, EasyTier) |
| PCL.Mac/Views/Multiplayer/MultiplayerPage.swift | Main multiplayer UI with room creation/joining workflows |
| PCL.Mac/Views/Multiplayer/MultiplayerSidebar.swift | Sidebar component for multiplayer section (currently empty) |
| PCL.Mac/ViewModels/MultiplayerViewModel.swift | Core multiplayer logic including server/client management and heartbeat |
| PCL.Mac/Managers/MessageBoxManager.swift | Dialog manager for user interactions |
| PCL.Mac/Managers/EasyTierManager.swift | EasyTier installation and lifecycle management |
| PCL.Mac/Components/MyCard.swift | Added limitHeight parameter for flexible card layouts |
| PCL.Mac/App/* | App configuration updates for multiplayer feature integration |
| PCL.Mac.Core/Utils/* | Utility additions including URLConstants, Architecture detection, FileUtils |
| PCL.Mac.xcodeproj/* | Project configuration for SwiftScaffolding package dependency |
| PCL.Mac/Assets.xcassets/Icons/* | New icons (IconCopy, IconExit) for multiplayer actions |
| PCL.Mac/Views/Tasks/TasksPage.swift | Minor layout adjustment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
本 PR 为 PCL.Mac.Refactor 添加了联机功能，使用了 SwiftScaffolding 库并实现了 Scaffolding 协议，支持与 HMCL 等启动器互通。
closes #30