Skip to content

[DRAFT] Feature/file picker select root #2556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: feature/pbs-25-09
Choose a base branch
from

Conversation

bp-cos
Copy link
Contributor

@bp-cos bp-cos commented May 2, 2025

  • Ticket: [Not Yet Available3]
  • Feature flag: n/a

Purpose

Add a new flow to the google drive using the google file picker

Summary of Changes

Add a new component to handle the GFP
Updated the existing code to display the correct components when needed

Screenshot(s)

N/A

Side Effects

Uncertain and could be interesting on how it reacts to other add-ons

QA Notes

Still in the draft phase

@bp-cos bp-cos requested review from adlius and brianjgeiger May 2, 2025 17:52
@bp-cos bp-cos changed the base branch from develop to feature/pbs-25-09 May 2, 2025 17:53
Copy link
Contributor

@adlius adlius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can tidy this up a bit by wrapping most of the stuff in template script tabs int o the Ember component.js file. One you load the https://apis.google.com/js/api.js script via the script tag, you have access to window.gapi and google globally. That means you can do google.picker.DocsView(google.picker.ViewId.FOLDERS) in ember component.ts file and it would work. We can move all the scrip tag logic to component.ts file this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants