[eng-7264] Added a new banner for all OSF preprints #2601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
futa-ikeda
approved these changes
Jul 15, 2025
app/preprints/detail/template.hbs
Outdated
| <Preprints::-Components::PreprintStatusBanner | ||
| @submission={{this.model.preprint}} | ||
| @provider={{this.model.provider}} | ||
| @isOSFBanner=true |
There was a problem hiding this comment.
Minor nit: I think this should be {{true}}, though it seems like it's working fine as is?
|
|
||
| declare const config: { | ||
| WATER_BUTLER_ENABLED: boolean; | ||
| PREPRINT_ADAPTER_OPTIONS_ENABLED: boolean; |
There was a problem hiding this comment.
I appreciate this idea, as it always takes me a few minutes to realize why my preprint detail page is broken 😄
app/preprints/detail/controller.ts
Outdated
| } | ||
|
|
||
| get showOSFBanner(): boolean { | ||
| return this.model.provider.id === 'osf'; |
There was a problem hiding this comment.
Nit: I don't think this is needed, as there may be some other criteria in the future to show this banner, but there is also the config.defaultProvider that may be appropriate to use here. We use it in other places to basically check the same thing, but it feels marginally more robust to be using a config rather than a hardcoded providerID
bp-cos
merged commit a4387ca
into
CenterForOpenScience:feature/pbs-25-12
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Added a "caveat" banner to all OSF preprints.
There will be 2 banners displayed on some preprints depending on the use case.
Summary of Changes
Added a conditional statement to the preprint details page to display a banner for all osf preprints
Added logic to the preprint-banner-display component to find the class and message and display the osf banner
Added a feature switch to the environment and router to prevent errors on displaying preprints locally
Screenshot(s)
Side Effects
Some OSF users will see 2 banners.
QA Notes
Enjoy