[SVCS-676] Further Improve Memory Usage for CSV rendering #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cslzchen
changed the title
cslzchen
force-pushed
the
bug-fix/csv-memory-leak
branch
from
cbcb523 to
1b8ddcf
Compare
- Dump sheets to a json var, delete the sheets before rendering. - Delete reader when exception happens - Update error message for TableTooBigError - Update comment and log for garbage collection
cslzchen
force-pushed
the
bug-fix/csv-memory-leak
branch
from
1b8ddcf to
ca1199d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBD