Skip to content

[ENG-7607][ENG-8357] Feature/unoserver integration #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mkovalua
Copy link

Ticket

https://openscience.atlassian.net/browse/ENG-8356

https://openscience.atlassian.net/browse/ENG-7606

https://openscience.atlassian.net/browse/ENG-7607

https://openscience.atlassian.net/browse/ENG-8357

Purpose

MFR Update unconv to unoserver (update poetry dependencies)

MFR Update code to use unoserver

Changes

replace UnoconvExporter code to unoserver

Side effects

QA Notes

Deployment Notes

@mkovalua mkovalua marked this pull request as ready for review July 21, 2025 14:59
@coveralls
Copy link

coveralls commented Jul 22, 2025

Coverage Status

coverage: 68.531% (-0.4%) from 68.979%
when pulling ed1b701 on mkovalua:feature/unoserver-integration
into 72a927c on CenterForOpenScience:feature/buff-worms.

Copy link
Collaborator

@opaduchak opaduchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small issues, rather than that, looks great!

Comment on lines +19 to +22
client = UnoClient(
server=UNOSERVER_HOST,
port=int(UNOSERVER_PORT),
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update osf.io docker-compose.yml to use unoserver instead of unoconv

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was done in seperate PR, as it had a seperate ticket -> CenterForOpenScience/osf.io#11228

pyproject.toml Outdated
@@ -40,7 +40,7 @@ h5py = "3.13"
scipy = "1.15.2"
markdown = "3.8.0"
certifi = "2025.1.31"
unoconv = "0.9.0"
unoserver = ">=3.2,<4.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to pin dependencies to specific patch, to have more predictable environment and instalations

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pinned to latest version (3.3.2) in latest commit

 * pin unoserver to specific version v3.3.2 (latest)

 * Update MFR code to use unoserver

 * PIL error fix

 * static files 404 error fix
@opaduchak opaduchak self-requested a review July 25, 2025 10:00
Copy link
Collaborator

@opaduchak opaduchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great! Thanks for all the effort!

@felliott felliott force-pushed the feature/unoserver-integration branch from a0d6b1e to ed1b701 Compare July 25, 2025 12:32
@felliott felliott merged commit 8aa8251 into CenterForOpenScience:feature/buff-worms Jul 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants