Skip to content

Feature/buff-worms (MFR python v3.13 upgrade) #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 116 commits into from
Nov 18, 2025
Merged

Feature/buff-worms (MFR python v3.13 upgrade) #407

merged 116 commits into from
Nov 18, 2025

Conversation

@felliott
Copy link
Member

@felliott felliott commented Nov 18, 2025

Ticket

https://openscience.atlassian.net/browse/ENG-7617

Purpose

Upgrade MFR to use python v3.13; add resumable doc conversion support

Changes

  • Upgrade MFR and dependencies to python v3.13.
  • Allow render jobs to be backgrounded and cached.
  • Switch from unoconv to unoserver; upgrade LibreOffice used to convert office files to pdf.
  • Switch to pyproject.toml and poetry.

Side effects

None expected.

QA Notes

QA completed!

Deployment Notes

Following items completed:
sentry test-1-mfr is create
in test, mfr.yaml is update
rabbitmq is deployed in all regions
jenkins job for both test and prod is updated with new helm chart version 0.9.3

mkovalua and others added 30 commits April 23, 2025 16:00
@mkovalua
ENG-7595 Update MFR Dockerfile and (dev-)requirements.txt files to ma…
de59e1e 
…ke it possible to create image and mfr-requirements, mfr containers for py3.13 without errors
@mkovalua
raven is outdated for py3.13 replace it with sentry_sdk to make it po…
dc995b9 
…ssible to build MFR 3.13 image and create containers afterward
@felliott
fix some dockerfile lints
943e5f7
@felliott
Merge branch 'feature/dockerfile-updates' into feature/buff-worms
f6b1adf 
 Closes #373
@mkovalua @felliott
fix Deprecated function, class, or module
44b707c
@mkovalua @felliott
fix incorrect call arguments
2466680
@mkovalua @felliott
fix Deprecated function, class, or module
9159990
@mkovalua @felliott
fix Incorrect type
be346fa
@mkovalua @felliott
fix Unbound local variables
672260c
@mkovalua @felliott
use pip install pyupgrade and find . -type f -name '*.py' -exec pyupg…
389c57a 
…rade --py313-plus {} \+ to convert code to python3.13 suitable format
@mkovalua @felliott
fix single quoted docstring
12cc556
@mkovalua @felliott
fix shadowing names from outer scopes
9eccd05
@mkovalua @felliott
fix redundant parentheses
b1fc8a3
@mkovalua @felliott
fix shadowing build in names
21af2e0
@mkovalua @felliott
fix Method is not declared static
c6a9490
@mkovalua @felliott
Todo: Qodana told about Dictionary can be rewritten by dictionary lit…
ab37d31 
…eral
@mkovalua @felliott
# Todo: not see Name implementation in child classes
0e3ca91
@mkovalua @felliott
# Todo: maybe it is needed to use logger and specific message for exc…
106e3de 
…eption logging
@mkovalua @felliott
fix Incorrect docstring (not confident about 'action' and 'metadata' …
9c6fb7c 
…type)
@mkovalua @felliott
add todo about mismatched signature
c3925b7
@felliott
Merge branch 'feature/py3.13-syntax-deprecations' into feature/buff-w…
87b5366 
…orms

 Closes #374
@mkovalua @felliott
Fixup Github Actions to start to run
1ce7762
@mkovalua @felliott
ci/cd yml update
8426f5b
@mkovalua @felliott
Update test-build.yml
4aa8b94
@felliott
Merge branch 'feature/update-gh-ci' into feature/buff-worms
e51d9ad 
 Closes #375
@mkovalua @felliott
update MFR dev-requirements.txt
651f07e
@mkovalua @felliott
update MFR doc-requirements.txt
48ff1a0
@felliott
Merge branch 'feature/dep-group-dev-doc' into feature/buff-worms
d722f6f 
  Closes #376
@futa-ikeda
Bump dependencies for ext-code and ext-doc
f978ec2
@felliott
Merge branch 'feature/dep-group-ext-code-doc' into feature/buff-worms
3dbe97e 
 Closes #377
opaduchak and others added 28 commits July 29, 2025 12:40
@opaduchak
Merge pull request #392 from opaduchak/fix/ENG-8472
ffaba86 
[ENG-8472] Files with Cyrillic in their names won't render
@sh-andriy
[ENG-8475] Fix unable to render spreadsheet files (.xls and .xlsx) (#393
d4da5a8 
)
@sh-andriy
fix(mfr): fix not all xlsx files render error
92a05d9
@opaduchak
Merge pull request #394 from sh-andriy/fix/xlsx-file-render-error
dc2a053 
fix(mfr): fix not all xlsx files render error
@opaduchak
[ENG-8488] MFR: .xlsx file not rendering correctly in OSF Storage (#396)
66b1859
@sh-andriy
[ENG-8489] Enforce MAX_SIZE on .xls rendering just like was on .xlsx (#…
231f5be 
…397)
@mkovalua
[ENG-8501] Upgrade tornado version to "6.5.1" (#399)
a54c91a
@sh-andriy
[ENG-8488] Fix inconsistent Excel rendering by enforcing binary mode …
9e2e128 
…for .xls/.xlsx (#401)
@sh-andriy @felliott
ENG-8426 | Update README with Poetry-based setup steps for local MFR …
5fa2054 
…development
@felliott
Merge branch 'feature/update-readme' into feature/buff-worms
7d7caad 
 Closes #402
 [ENG-8426]
@Vlad0n20 @felliott
Update readthedocs config
73b02b7
@felliott
update sphinx documentation meta and build
3fa803e
@felliott
Merge branch 'feature/rtd-updates' into feature/buff-worms
6498822 
 Closes #403
 [ENG-8427]
@felliott
flake fix in rtd conf
18c07ca
@felliott
Merge branch 'feature/rtd-flake-fix' into feature/buff-worms
374d392
@opaduchak @felliott
removed libreoffice install from dockerfile
983f5ce
@felliott
Merge branch 'feature/fix-docker-build' into feature/buff-worms
69b7309 
 Closes #405
 [ENG-8674]
@mkovalua @felliott
add ruff formatting option
c7b3018
@mkovalua @felliott
remove redundant extend-ignore constraints
5fd07dc
@felliott
Merge branch 'feature/ruff-support' into feature/buff-worms
a080e58 
 Closes #400
 [ENG-8423]
@opaduchak @felliott
Added Celery-powered render
7b643df 
 * docs: add plugin list to rtd docs

 * release some aiohttp responses
@felliott
Merge branch 'feature/unoserver-celery' into feature/buff-worms
0f0b4e8 
 Closes #391
 [ENG-7610]
@sh-andriy @felliott
ENG-8627 | Fix .3ds files not rendering in MFR viewer
e9f9e06
@felliott
Merge branch 'feature/fix-3ds' into feature/buff-worms
aea8068 
 Closes #404
 [ENGR-8627]
@Vlad0n20 @felliott
Fix search in .xlsx files
7ff05de
@felliott
Merge branch 'feature/fix-xlsx-search' into feature/buff-worms
2ddf4a9 
 Closes #406
 [ENG-8626]
@felliott
update wb dep for oathpit workaround
9006ee7
@felliott
Merge branch 'feature/oathpit' into feature/buff-worms
8e3a82a 
 * Update MFR to install waterbutler with workaround for small file
   downloads.
@felliott felliott merged commit 79117b3 into develop Nov 18, 2025
4 checks passed
@coveralls
Copy link

coveralls commented Nov 18, 2025

Coverage Status

coverage: 69.665% (-1.7%) from 71.329%
when pulling 8e3a82a on feature/buff-worms
into a7ef407 on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@felliott @coveralls @mkovalua @futa-ikeda @sh-andriy @opaduchak @Vlad0n20