Add assertions for OSFI affiliations on preprint rewiev and detail pages #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jh27539
reviewed
Jun 6, 2025
tests/test_preprints.py
Outdated
| affiliated_institutions_names_metadata_page | ||
| == affiliated_institutions_names_review_page | ||
| ), ( | ||
| f'Affiliated institutions on the Review Page do not match expected values.\n' |
Collaborator
There was a problem hiding this comment.
Looks like we are copy/pasting this assertion multiple times in this pull request. Is it possible to make a re-usable assertion statement?
Shtogryn
force-pushed
the
pshtohryn/ENG-6198/feature/osfi-affiliations-assertions
branch
from
90064aa to
c5b8ff2
Compare
jh27539
deleted the
pshtohryn/ENG-6198/feature/osfi-affiliations-assertions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add assertions for OSFI affiliations to the following pages:
Preprint Review Page
Preprint Detail Page
Summary of Changes
Updated :
Reviewer's Actions
git fetch origin pull/284/head:pshtohryn/ENG-6198/feature/osfi-affiliations-assertionsRun this test using
pytest tests/test_preprints.py::TestPreprintWorkflow::test_create_preprint_from_landing -svpytest tests/test_preprints.py::TestPreprintWorkflow::test_edit_preprint -svTesting Changes Moving Forward
Ticket
https://openscience.atlassian.net/browse/ENG-6198
https://openscience.atlassian.net/browse/ENG-6723