Skip to content

Conversation

bodintsov
Copy link
Contributor

Purpose

Notifications to be created with the normal request context using the new model.

Changes

TBD

QA Notes

TBD

Documentation

TBD

Side Effects

TBD

Ticket

https://openscience.atlassian.net/browse/ENG-8084

…cience/osf.io into add-new-notifications-data-model

* 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io:
  [ENG-7965] Add v2 email token confirmation endpoints (CenterForOpenScience#11139)
…cience/osf.io into add-new-notifications-data-model

* 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io:
  fix issue where not having any external identities caused a 500
…cience/osf.io into add-new-notifications-data-model

* 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io:
  [ENG-7966] Add "collected-in" relationship for Nodes (CenterForOpenScience#11140)
…cience/osf.io into add-new-notifications-data-model

* 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io:
  fix issue where trying another already confirmed email threw an uncaught exception (CenterForOpenScience#11161)
  [ENG-8148] Add ArtifactOutcome in annotations to linked nodes  (CenterForOpenScience#11158)
…OpenScience/osf.io into add-new-notifications-data-model

* 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io:
  flake8
  fixed tests
  remove quickfiles
  update mails mock
  Update send_mail mocks
  Clean up tests
  Clean up tests
  Clean up imports
  Remove Meetings, Comments and OSF Groups Notifications
  remove osf groups
  remove osf groups
  remove osf groups
  remove osf groups
  remove osf groups

# Conflicts:
#	tests/test_notifications.py
…cience/osf.io into add-new-notifications-data-model

* 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io:
  Update hybrid values for new workflow check (CenterForOpenScience#11166)
…OpenScience/osf.io into add-new-notifications-data-model

* 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io:
  ignore Django maintenance state outside block
…OpenScience/osf.io into add-new-notifications-data-model

* 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io:
  fixed bug with contributors
  remove superfluildous `groups` from serializer
  fix new and noteworth nodes bug going to Sentry
Copy link
Contributor

@Johnetordoff Johnetordoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you did the correct objective, but I notice failing unittests, please fix them and re-submit.

@bodintsov bodintsov force-pushed the feature/upgrade-adding-contributor-notifications branch from 73f2ed8 to d30f868 Compare June 24, 2025 09:35
…cience/osf.io into add-new-notifications-data-model

* 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io:
  fixed None issue when iterate (CenterForOpenScience#11192)
  [ENG-8048] Remove caching to avoid incorrect results for ascendants (CenterForOpenScience#11169)
  [ENG-7870] Crossref DOIs not minting with _v1, OSF is displaying DOI versions with _v1 (CenterForOpenScience#11154)
  Update changelog and package.json
  [ENG-8145] [ENG-8147] Manual DOI and GUID for Preprints & Registrations - BE (CenterForOpenScience#11174)
…cience/osf.io into add-new-notifications-data-model

* 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io:
  Revert "[ENG-8048] Remove caching to avoid incorrect results for ascendants (…"
  Revert "fixed None issue when iterate (CenterForOpenScience#11192)"
@bodintsov bodintsov force-pushed the feature/upgrade-adding-contributor-notifications branch from d30f868 to dc63745 Compare July 7, 2025 09:08
Johnetordoff and others added 11 commits July 7, 2025 10:27
 into add-new-notifications-data-model

* 'develop' of https://github.com/CenterForOpenScience/osf.io:
  Bump version no. Add CHANGELOG
  move CROSSREF_UNAVAILABLE_DELAY to settings.py
  handle and 5xx status code from crossref
  handle 500 error from crossref
  Update changelog and package.json
 into refactor-notifications

* 'develop' of https://github.com/CenterForOpenScience/osf.io:
  Update chagnelog and bump version
  [ENG-6835] VRL Project PR - BE (CenterForOpenScience#11204)

# Conflicts:
#	api_tests/registrations/views/test_registration_detail.py
#	conftest.py
#	tests/test_registrations/test_retractions.py
…/user_confirmation

Feature/user confirmation
…rdoff/osf.io into add-new-notifications-data-model

* 'add-new-notifications-data-model' of github.com:johnetordoff/osf.io:
  fix unit tests
  fix unit tests
  fix unit tests
  fix unit tests
  fix unit tests
  fix unit tests
  Upgrade User Confirmation Registrations
@Johnetordoff Johnetordoff force-pushed the refactor-notifications branch from afc3815 to b6bbeed Compare July 11, 2025 13:02
@bodintsov bodintsov force-pushed the feature/upgrade-adding-contributor-notifications branch from dc63745 to a9241eb Compare July 15, 2025 12:57
@bodintsov bodintsov force-pushed the feature/upgrade-adding-contributor-notifications branch from 9d9192a to 0bd2e70 Compare July 18, 2025 09:23
@Johnetordoff
Copy link
Contributor

I cherry picked this into the new notification model branch consider merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants