Skip to content

Conversation

@SeaUrc
Copy link

@SeaUrc SeaUrc commented Oct 20, 2025

No description provided.

Copy link
Contributor

@milo157 milo157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More code hygiene things but otherwise I think it looks good.

I would add a basic readme on:

  • What this repo contains
  • What order/commands should I use to run (ie: pip install requirements, find markets, cerebrium deploy and then compare etc)

poly_market = getMarket(False, poly_slug)
question = poly_market['question'] # we use polymarket because they have direct question

kalshi_real_yes = float(kalshi_market['market']['yes_ask'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are kalshi and polymarket returning values in the same way? I would handel the yes/no in the get market function so it makes this easier to follow and so it handles they have the same return format

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, they have different response schemas but I think I can refactor for cleaner code

}

try:
async with session.post(endpoint_url, headers=headers, data=payload) as response:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think axios might be much clearner than aiohttp. There a reason you used it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand. How would I use Axios in a python script? Axios is used in node

total_markets = len(results)

kalshi_edges = [r['kalshi_edge'] for r in results]
total_kalshi_edge = sum(kalshi_edges)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its tough to know if this is a count or money. Also is money in dollars or cents?

Copy link
Author

@SeaUrc SeaUrc Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it more clear. Money is in cents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants