Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade HtmlToOpenXml to v3.1.0 #59

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Conversation

onizet
Copy link
Contributor

@onizet onizet commented Aug 31, 2024

I'm the author of HtmlToOpenXml.dll package. I did a big refactoring work on this library to be more stable and parsing efficient. I have also fixed numerous bugs.

I'd really like to encourage you to update the dependency.

@mesquidar
Copy link
Member

mesquidar commented Sep 1, 2024

Hi @onizet first of all thank for your work on the library :)
I built a dev image with the new version 3.1.0 and we are testing it.

Some of the users found some issues you can check it here: #51 (comment)

Thank you :)

@onizet
Copy link
Contributor Author

onizet commented Sep 1, 2024

Hello @mesquidar, thank you for your quick feedback.
I fixed that issue 3 weeks ago #onizet/html2openxml/issues/113
Let me know if you are still facing that issue.

@mesquidar
Copy link
Member

Hi @onizet thanks for your answer :)

Unfortunately the issue persists with the new version 3.1.0
Another thing that some user notice is there some issues with image align you can see the comment #51 (comment)

Thanks!

@onizet
Copy link
Contributor Author

onizet commented Sep 4, 2024

Hi Ruben, I have just release v3.1.1 which contain the bug fix mentioned in issue 51.
Table layout is correctly handled in v3+
The image alignment is currently not supported (float: right) but I'm working on it. That's not easy as OpenXml <> HTML and sometimes, this is just not possible to conform fully to Html5 standard.

@mesquidar
Copy link
Member

Hi @onizet thanks for the update :)
I will take it a look at the new version

@mesquidar mesquidar merged commit 1fc0966 into CervantesSec:master Sep 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants