Fix/disable input on ask #1861
Draft
Fix/disable input on ask #1861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamylio
force-pushed
the
fix/disable-input-on-ask
branch
from
315492e to
0cf1659
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Small modification that I think is could prevent confusion of end-users. When a
AskUser*component is sent, the ability to send messages is disabled (the send button, the settings and so on), yet the "text-area" is not, and the placeholder still shows "Type your message here..." even if we can't.This PR aims to fix this.
Note: I've also though of creating a new translation
chat.input.disabledinstead of it being empty, so LMK.Before:
After:
PS. Sorry for the double PR, selected wrong branch.