Skip to content

Conversation

@eiseleMichael
Copy link
Contributor

@eiseleMichael eiseleMichael commented Nov 26, 2025

  • feat: improves icon name formatting by preserving correct icon names. Correct names such as ChevronRight where formatted wrongly
  • chore: update lucide-react to include latest icons

Summary by cubic

Improved the Icon component’s name formatting so icons resolve correctly from kebab-case, lowercase, PascalCase, uppercase, and mixed-case inputs. Updated lucide-react to the latest version for new icons.

  • Bug Fixes

    • Updated formatIconName to preserve PascalCase, normalize kebab-case to PascalCase, and clean up all-uppercase and mixed-case names.
    • Added tests for kebab-case, lowercase, PascalCase, uppercase, mixed-case, invalid names (warn + null), and prop forwarding.
  • Dependencies

    • Bumped lucide-react from 0.468.0 to 0.555.0.

Written for commit d51145a. Summary will update automatically on new commits.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. frontend Pertains to the frontend. labels Nov 26, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 4 files

Prompt for AI agents (all 1 issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="frontend/src/components/Icon.tsx">

<violation number="1" location="frontend/src/components/Icon.tsx:17">
Icon names that contain a hyphen followed by an uppercase letter are no longer normalized (the hyphen remains), so inputs like &quot;chevron-Right&quot; or &quot;CHEVRON-RIGHT&quot; do not resolve to a valid Lucide icon.</violation>
</file>

Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Pertains to the frontend. size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant