This repository was archived by the owner on Aug 5, 2025. It is now read-only.
Allow step end_time overwrite #170
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fix: Preserve manually set
end_timeonStep.end()Context
When using the
withsyntax to log a step, we sometimes manually setstart_timeandend_time(e.g. to match historical timestamps or upsert an existing thread).However, the current implementation of
Step.end()always overwritesend_timewithutc_now(), which can lead to inaccurate timing data.Change
Updated the
end()method to preserve the manually-setend_timeif it already exists:Example of
end_timeoverwritingNow correctly logs
completed_atinstead of the current time.Why it matters
This ensures accurate time tracking when steps are being reconstructed or backfilled, and avoids unintentionally overwriting data.