feat: implement EIP-165 compliance and silence test warnings#11
Open
mandip-kamaliya wants to merge 1 commit intoChaosChain:mainfrom
Open
feat: implement EIP-165 compliance and silence test warnings#11mandip-kamaliya wants to merge 1 commit intoChaosChain:mainfrom
mandip-kamaliya wants to merge 1 commit intoChaosChain:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds EIP-165 support to the IdentityRegistry and optimizes the test suite to ensure a warning-free compilation.
Key Changes
EIP-165 Implementation: Implemented the supportsInterface function to allow on-chain discovery of the IIdentityRegistry interface. This ensures the registry is compatible with other protocols and marketplaces that query for supported interfaces.
Test Suite Optimization: Updated specific test functions to view visibility where state modification was not required. This removes compiler warnings during the forge test process, leading to a cleaner developer experience.