Fix: the issue where custom values cannot be selected when the default value of CUSTOM_MODELS includes -all.

[yooyui]

💻 变更类型 | Change Type

• feat
• fix
• refactor
• perf
• style
• test
• docs
• ci
• chore
• build

🔀 变更说明 | Description of Change

📝 补充信息 | Additional Information

Summary by CodeRabbit

• Bug Fixes
  • Adjusted the order of parameters in the model collection function, potentially improving model selection accuracy based on the latest data configurations.

[vercel]

@yooyui is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Walkthrough

The recent changes enhance the useAllModels function in app/utils/hooks.ts by modifying the order of parameters passed to collectModelsWithDefaultModel. This adjustment changes how customModels from accessStore and configStore are combined, potentially impacting model selection and application behavior. While the control flow remains unchanged, the semantic meaning of the inputs has shifted, warranting closer attention to the implications on model configuration.

Changes

File	Change Summary
app/utils/hooks.ts	Reordered parameters in collectModelsWithDefaultModel within useAllModels to prioritize accessStore.customModels over configStore.customModels.

Poem

In a world of models, we hop and play,
With changes afoot, let's cheer today!
From access to config, the order's askew,
Collecting with care, our choices are new.
So let’s twirl and dance, a rabbit's delight,
For models unite, making everything right! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Your build has completed!

Preview deployment

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 87325fa and 09b56c9.

Files selected for processing (1)

• app/utils/hooks.ts (1 hunks)

Additional comments not posted (1)

app/utils/hooks.ts (1)

11-11: Verify the impact of the parameter order change on model selection.

The order of customModels from accessStore and configStore has been swapped. This change may affect how models are prioritized or selected. Ensure that this modification resolves the issue with CUSTOM_MODELS including -all and does not introduce any unintended side effects.

[yooyui]

Fix implemented by swapping the code in app/utils/hooks from configStore.customModels, accessStore.customModels to accessStore.customModels, configStore.customModels.

Closes #5277