Skip to content

[25.07.12 / TASK-92] Refactor - API에 Sentry 추가 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 13, 2025
Merged

[25.07.12 / TASK-92] Refactor - API에 Sentry 추가 #40

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c43398e
refactor: 최소 설정으로 Sentry 연결
six-standard Jul 10, 2025
9c70935
refactor: 디버그 관련 코드 비활성화
six-standard Jul 12, 2025
bf33d9d
refactor: 릴리즈 타입 설정
six-standard Jul 12, 2025
39c91f4
refactor: 네이밍 이슈 관련 수정
six-standard Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .env.sample
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,4 @@ POSTGRES_PORT=5432
# ETC
SLACK_WEBHOOK_URL=https://hooks.slack.com/services
SLACK_CLIENT_SECRET=374708bedd34ae70f814471ff24db7dedc4b9bee06a7e8ef9255a4f6c8bd9049 # 실제 키를 사용하세요
SLACK_DSN=https://ingest.us.sentry.io
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

환경변수... 주의 부탁 드립니다.. 네이밍... 이번에도..ㅠㅠ

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분을 제가 계속 놓치고 있었던 것 같네요;;
슬랙 쪽에서 발급받는 부분은 SLACK, 센트리 쪽에서 발급받는 부분은 SENTRY로 통일하는게 좋을 것 같습니다!
물론 두 값 사이에 줄바꿈은 넣어야 할 것 같네요

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@six-standard 그 도메인을 나누는 데에는 전혀 이견 없습니다.
근데 제가 말드리고 있는 포인트는 지금 PR에서 기준님은 전혀 지금 SLACK 이랑 관련된 값을 건들이지 않았어요. 지금은 철저하게 SENTRY 관련된 값입니다.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이해했습니다.
말씀해주신대로 수정해서 반영했습니다!

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"author": "",
"license": "ISC",
"dependencies": {
"@sentry/node": "^9.36.0",
"axios": "^1.7.8",
"class-transformer": "^0.5.1",
"class-validator": "^0.14.1",
Expand Down
Loading
Loading