fix: scope sed to Identity element when bumping VSIX version#337
Merged
Conversation
Broad pattern was replacing all Version attributes in the manifest, including the required PackageManifest Version="2.0.0", causing VSSDK1061 build error. Scoped to Identity element only.
Contributor
Security Policy Alert: Actions Policy ViolationThis workflow run has been blocked by StepSecurity's actions policy. Disallowed Actions:
To fix this issue, please modify the workflow to use only allowed actions. Contact your organization administrator to request changes to the allowed actions list if needed. For more information, see StepSecurity's Actions Policy documentation. |
Contributor
Security Policy Alert: Actions Policy ViolationThis workflow run has been blocked by StepSecurity's actions policy. Disallowed Actions:
To fix this issue, please modify the workflow to use only allowed actions. Contact your organization administrator to request changes to the allowed actions list if needed. For more information, see StepSecurity's Actions Policy documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sedpattern introduced in Replace third-party VSIX action and use GITHUB_TOKEN #335 was replacing allVersion="..."attributes in the manifest, including the requiredPackageManifest Version="2.0.0"VSSDK1061: 'PackageManifest' element requires a Version equal to '2.0.0'build failureIdentityelement'sVersionattributeRoot cause
s/Version="[^"]*"/Version="$version"/matches everyVersion=in the file. The manifest has several:PackageManifest Version="2.0.0"← must stay fixedIdentity ... Version="x.x"← this is the one to bumpInstallationTarget Version="[17.0, 18.0)"← must stay fixed