π‘οΈ Sentinel: [CRITICAL] Fix command injection in system-handlers.ts#383
Conversation
- **π¨ Severity:** CRITICAL - **π‘ Issue:** The `set_cvar` handler in `system-handlers.ts` interpolated unsanitized user inputs (`rawName` and `value`) directly into console command strings. This allowed attackers to inject arbitrary console commands (e.g., `value; Quit;`). - **π― Impact:** Remote code execution / arbitrary console command execution within the Unreal Engine editor via the automation bridge. - **π§ Fix:** Sanitized `rawName` and `value` using `sanitizeCommandArgument` before interpolating them into the console command string, and updated the response payload to return the sanitized values for consistency. - **β Verification:** Ran `npm run lint`, `npm run type-check`, `npm run test:unit`, and `npm run build` to verify standard functionality and ensuring no regressions occurred. - **π Pattern Used:** Used `sanitizeCommandArgument` from `src/utils/validation.ts` applied to all dynamically inserted parts of the console command string as well as validating for empty inputs.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
set_cvarhandler insystem-handlers.tsinterpolated unsanitized user inputs (rawNameandvalue) directly into console command strings. This allowed attackers to inject arbitrary console commands (e.g.,value; Quit;).rawNameandvalueusingsanitizeCommandArgumentbefore interpolating them into the console command string, and updated the response payload to return the sanitized values for consistency.npm run lint,npm run type-check,npm run test:unit, andnpm run buildto verify standard functionality and ensuring no regressions occurred.sanitizeCommandArgumentfromsrc/utils/validation.tsapplied to all dynamically inserted parts of the console command string as well as validating for empty inputs.PR created automatically by Jules for task 3390057170719728878 started by @ChiR24