Skip to content

Add PagingQueryableExtensions for Marten #8260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

s3w3nofficial
Copy link

I have ported the ToPageAsync extension method from GreenDonut.Data.EntityFramework with some marten specific changes.

Currently it supports all the types as the ef core version except:

  • datetime
  • ulong
  • ushort

Closes #8251

@CLAassistant
Copy link

CLAassistant commented Apr 21, 2025

CLA assistant check
All committers have signed the CLA.

@michaelstaib
Copy link
Member

How did you handle ToBatchPageAsync? we have already a port for ToPageAsync but ToBatchPageAsync does not work with marten as of now. Marten will need to implement GroupBy support for this.

@michaelstaib michaelstaib self-requested a review April 28, 2025 07:41
@michaelstaib michaelstaib marked this pull request as draft April 28, 2025 07:41
@s3w3nofficial
Copy link
Author

How did you handle ToBatchPageAsync? we have already a port for ToPageAsync but ToBatchPageAsync does not work with marten as of now. Marten will need to implement GroupBy support for this.

I did not try to implement the ToBatchPageAsync since the GroupBy is not supported.

@michaelstaib
Copy link
Member

We are talking at the moment with Jeremy to get some changes into the queryable provider thats why we do not have a provider as of now ... I will leave this as a draft open. But I do not want to have it in this state. Especially as I want to share more between drivers and allow for easier maintainability.

@michaelstaib
Copy link
Member

@s3w3nofficial we will soon pick this back up ... sorry for the wait. I will include you in the work as soon as we have the main bulk for the new type system abstractions merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PagingQueryableExtensions for Marten
3 participants