Skip to content

Conversation

tobias-tengler
Copy link
Member

I removed this in #8758, since there were no references and it felt like a really obscure option... Turns out we're using it in Nitro, so I'm re-adding it.

@Copilot Copilot AI review requested due to automatic review settings October 14, 2025 17:46
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR re-adds the RequestExecutorSetup.SchemaBuilder property that was previously removed, as it's needed by the Nitro project. The change restores the ability to provide a custom schema builder while maintaining backward compatibility.

  • Re-adds the SchemaBuilder property to RequestExecutorSetup
  • Simplifies the SchemaBuilder constructor to use default options
  • Updates the request executor creation logic to use the provided schema builder or create a new default one

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
SchemaBuilder.cs Simplified constructor to use default schema options and removed internal overload
RequestExecutorManager.cs Updated to use the schema builder from setup and moved schema options creation logic
SchemaRequestExecutorBuilderExtensions.cs Enhanced options modification to work with both schema builder and option modifiers
RequestExecutorSetup.cs Re-added the SchemaBuilder property and updated copy logic
RequestExecutorWarmupService.cs Added local implementation of schema options creation method

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tobias-tengler tobias-tengler merged commit 7d1bc0c into main Oct 14, 2025
111 checks passed
@tobias-tengler tobias-tengler deleted the tte/re-add-setup-schemabuilder branch October 14, 2025 20:26
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (12bfd27) to head (4f96585).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #8810   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant