Fix: Make ResistiveWallPseudomode parameters dynamically propagate #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ResistiveWallPseudomodecalledPseudomodeWakefield.__init__in__post_init__, which stored a static mode list (_modes) at creation time. If a user later modified parameters likeradius, the stored mode was not updated, causing incorrect wakefield calculations.Solution
Replaced the static
_modesattribute with a dynamic@propertythat recomputes the pseudomode from current parameters on each access.Changes
PseudomodeWakefield.__init__call from__post_init___modesproperty that dynamically returns[self._create_mode()]Verification