Skip to content

🛡️ Sentinel: Fix timing side-channel vulnerability in API key verification - #452

Open
ightevenmckane187 wants to merge 1 commit into
mainfrom
sentinel-constant-time-auth-check-10152525788508241593
Open

🛡️ Sentinel: Fix timing side-channel vulnerability in API key verification#452
ightevenmckane187 wants to merge 1 commit into
mainfrom
sentinel-constant-time-auth-check-10152525788508241593

Conversation

@ightevenmckane187

Copy link
Copy Markdown
Collaborator

🛡️ Sentinel Security Improvement

  • Vulnerability: Standard string equality (!=) in verify_api_key in auth.py was vulnerable to timing side-channel attacks where an attacker could measure execution duration differences to deduce valid API key/token characters.
  • Fix: Replaced standard inequality check with hmac.compare_digest(provided_key, CYPHER_API_KEY) to ensure constant-time comparison.
  • Testing: Added test_api_create_share_link_timing_safety in tests/test_share_system.py asserting proper 401/403 responses across various key formats and lengths. All Python and TypeScript unit test suites pass cleanly.

PR created automatically by Jules for task 10152525788508241593 started by @ightevenmckane187

Harden `verify_api_key` in `auth.py` by replacing standard string inequality comparison with `hmac.compare_digest` to prevent timing side-channel attacks during authentication token verification. Add test coverage in `tests/test_share_system.py` to assert secure rejection of invalid API keys across key formats and lengths.
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant