New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow inline comments in clamd.conf #1308

Open

userwiths wants to merge 1 commit into Cisco-Talos:main from userwiths:fix/allow-inline-comments

+8 −3

Contributor

userwiths commented Jul 11, 2024

This PR attempts to resolve the issue mentioned in #1175

Regex has been changed in order to allow matching a given line even if it has a comment (separated with space or not) from the main expression.
When passing through an argument, check if it contains the comment character # and if it does, try to get the content on its left side.

Thoughts:

I have some doubts strtok is the best choice.
Another approach, better imo, would be to get the first match from the regex expression. I failed to find an example in the project where cli_regexec returns the made matches (most likely in the 4th argument, but it seems its used mostly with NULL through out the project).


          fix: Allow inline comments in clamd.conf

ef7d483

userwiths mentioned this pull request

Clamd can't start if clamd.conf contains inline comments #1175

Open

Contributor

micahsnyder commented Jul 19, 2024

Thanks for the PR! I will try to review this after we have things lined up to publish 1.4.0, or after 1.4.0 ships.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet