enhancement for node_mgmt_epg_to_contract (DCNE-87)#658
Merged
lhercot merged 17 commits intoCiscoDevNet:masterfrom Jul 16, 2025
Merged
enhancement for node_mgmt_epg_to_contract (DCNE-87)#658lhercot merged 17 commits intoCiscoDevNet:masterfrom
lhercot merged 17 commits intoCiscoDevNet:masterfrom
Conversation
akinross
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
sajagana,
samiib and
shrsr
github-actions
Bot
changed the title
Ziaf007
force-pushed
the
node_mgmt_epg_to_contract
branch
2 times, most recently
from
820f4cc to
2873077
Compare
samiib
requested changes
Oct 25, 2024
akinross
requested changes
Dec 17, 2024
akinross
requested changes
Feb 3, 2025
akinross
reviewed
Mar 20, 2025
shrsr
requested changes
Mar 20, 2025
gmicol
requested changes
Mar 25, 2025
Collaborator
gmicol
left a comment
gmicol
left a comment
There was a problem hiding this comment.
Black formatting and Sanity tests failed, can you please fix it?
Collaborator
akinross
requested changes
Apr 15, 2025
Comment on lines
+103
to
+104
| - inb_provide_present_check_mode.sent.fvRsProv.attributes.dn == "uni/tn-mgmt/mgmtp-default/inb-anstest_inb/rsprov-aci_inb_http" | ||
| - inb_provide_present_check_mode.sent.fvRsProv.attributes.tnVzBrCPName == 'aci_inb_http' |
Collaborator
There was a problem hiding this comment.
for checkmode we should check proposed in instead of sent
Suggested change
| - inb_provide_present_check_mode.sent.fvRsProv.attributes.dn == "uni/tn-mgmt/mgmtp-default/inb-anstest_inb/rsprov-aci_inb_http" | |
| - inb_provide_present_check_mode.sent.fvRsProv.attributes.tnVzBrCPName == 'aci_inb_http' | |
| - inb_provide_present_check_mode.proposed.fvRsProv.attributes.dn == "uni/tn-mgmt/mgmtp-default/inb-anstest_inb/rsprov-aci_inb_http" | |
| - inb_provide_present_check_mode.proposed.fvRsProv.attributes.tnVzBrCPName == 'aci_inb_http' |
| ansible.builtin.assert: | ||
| that: | ||
| - consume_absent_check_mode is changed | ||
| - consume_absent_check_mode.previous.0.fvRsCons is defined |
Collaborator
There was a problem hiding this comment.
can you also assert the attributes of previous?
sajagana
requested changes
Jul 9, 2025
| description: | ||
| - Bind Node Management EPGs to Contracts on Cisco ACI fabrics. | ||
| notes: | ||
| - The C(epg) and C(contract) used must exist before using this module in your playbook. |
Collaborator
There was a problem hiding this comment.
Suggested change
| - The C(epg) and C(contract) used must exist before using this module in your playbook. | |
| - The O(epg) and O(contract) used must exist before using this module in your playbook. |
…ontract.url does not exist remain
…e PR. Shall test to merge Root and SubClass-1 into a single Root class now
2) fixed some linting 3) modified the query assertations accordingly in test file All checks passed in test file. PLAY RECAP ********************************************************************* azure_cloud : ok=8 changed=0 unreachable=0 failed=0 skipped=51 rescued=0 ignored=0 cn-dmz-apic-m1-02-v42 : ok=7 changed=0 unreachable=0 failed=0 skipped=52 rescued=0 ignored=0 cn-dmz-apic-m1-03-v52 : ok=55 changed=24 unreachable=0 failed=0 skipped=4 rescued=0 ignored=8 cn-dmz-apic-m1-04-v602h : ok=55 changed=24 unreachable=0 failed=0 skipped=4 rescued=0 ignored=8 Module ready for review
…seem to fail. Pushing to branch so one can pull to their local and test
…g block. Fixed some typos
Ziaf007
force-pushed
the
node_mgmt_epg_to_contract
branch
from
4039642 to
c00a359
Compare
Member
|
Thank you for the contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-) Added node_mgmt_epg_to_contract module
-) Test.yml still pending, working on it.
DCNE-87