Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ndo_node_setting module to manage Fabric Node Settings (DCNE-67) #557

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added ndo_node_setting module to manage Fabric Node Settings (DCNE-67) #557

wants to merge 5 commits into from

Conversation

sajagana
Copy link
Collaborator

No description provided.

@sajagana sajagana linked an issue Oct 28, 2024 that may be closed by this pull request
Enhancement: New module for Node Settings in Fabric Fabric Policies Template (DCNE-67) #443
Open
@sajagana sajagana added the jira-sync Sync this issue to Jira label Oct 28, 2024
@github-actions github-actions bot changed the title Added ndo_node_setting module to manage Fabric Node Settings Added ndo_node_setting module to manage Fabric Node Settings (DCNE-67) Oct 28, 2024
akinross
akinross requested changes Oct 29, 2024
View reviewed changes
tests/integration/targets/ndo_node_setting/tasks/main.yml Outdated Show resolved Hide resolved
plugins/modules/ndo_node_setting.py Outdated Show resolved Hide resolved
plugins/modules/ndo_node_setting.py Show resolved Hide resolved
akinross
akinross requested changes Oct 30, 2024
View reviewed changes
plugins/modules/ndo_node_setting.py Outdated Show resolved Hide resolved
anvitha-jain
anvitha-jain requested changes Oct 30, 2024
View reviewed changes
plugins/modules/ndo_node_setting.py Outdated Show resolved Hide resolved
plugins/modules/ndo_node_setting.py Outdated Show resolved Hide resolved
plugins/modules/ndo_node_setting.py Show resolved Hide resolved
plugins/modules/ndo_node_setting.py Outdated Show resolved Hide resolved
akinross
akinross previously approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr requested changes Oct 31, 2024
View reviewed changes
plugins/modules/ndo_node_setting.py Outdated Show resolved Hide resolved
plugins/modules/ndo_node_setting.py Outdated Show resolved Hide resolved
plugins/modules/ndo_node_setting.py Outdated Show resolved Hide resolved
plugins/modules/ndo_node_setting.py Outdated Show resolved Hide resolved
plugins/modules/ndo_node_setting.py Outdated Show resolved Hide resolved
plugins/modules/ndo_node_setting.py Outdated Show resolved Hide resolved
plugins/modules/ndo_node_setting.py Outdated Show resolved Hide resolved
plugins/modules/ndo_node_setting.py Outdated Show resolved Hide resolved
akinross
akinross previously approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shrsr shrsr requested review from samiib and akinross November 8, 2024 23:06
shrsr
shrsr approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sajagana sajagana requested a review from gmicol November 14, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samiib samiib samiib approved these changes

@shrsr shrsr shrsr approved these changes

@lhercot lhercot Awaiting requested review from lhercot lhercot is a code owner

@anvitha-jain anvitha-jain Awaiting requested review from anvitha-jain anvitha-jain is a code owner

@akinross akinross Awaiting requested review from akinross akinross is a code owner

@gmicol gmicol Awaiting requested review from gmicol gmicol is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
jira-sync Sync this issue to Jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: New module for Node Settings in Fabric Fabric Policies Template (DCNE-67)
6 participants
@sajagana @shrsr @akinross @anvitha-jain @samiib @gmicol