Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: admin service idp filter and wrong param names #474

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

voneiden
Copy link
Contributor

@voneiden voneiden commented Mar 7, 2024

Ref HP-2169

This was a bit funky because the IDP is stored in an ArrayField.

@voneiden voneiden requested a review from a team March 7, 2024 08:11
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 95.48%. Comparing base (dc3ecb4) to head (7400e4f).
Report is 1 commits behind head on main.

Files Patch % Lines
services/admin.py 53.33% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
- Coverage   95.56%   95.48%   -0.08%     
==========================================
  Files         207      207              
  Lines        8222     8235      +13     
  Branches      991      994       +3     
==========================================
+ Hits         7857     7863       +6     
- Misses        279      286       +7     
  Partials       86       86              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@voneiden voneiden merged commit 1e64d9b into main Mar 7, 2024
5 checks passed
@voneiden voneiden deleted the fix-admin-service-idp-filter branch March 7, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants