Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This primarily removes MetaUtils (#793) and modernises ItemUtils. The bulk of the changes in this PR is the renaming of, for example,
setDisplayName
tosetLegacyDisplayName
so thatsetComponentDisplayName
can just besetDisplayName
.The "legacy" methods still use
ItemMeta
instead of using data components because I cannot guarantee thatLegacyComponentSerializer
serialises components the same way thatItemMeta
does, sinceItemMeta
usesCraftChatMessage
internally.I've also removed the varargs variants of the "set" and "add" lore methods: there were (and still are) far too many sequential
addLore
calls adding only a single line each time. If people are forced to doList.of()
then maybe they'll collect it all into a single call... one can hope.I've also added
getCustomData
andeditCustomData
and updated ItemExchange to use them: the current code is adequate but brittle and inefficient.This also updates the DebugWand hack to use CivModCore's
CustomItem
interface. I want to move as many things away from theItemUtils#areItemsSimilar
(and consequentlyChatUtils#areComponentsEqual
) as possible.