Skip to content

fix(security): slugify entry_type before using it in the fabric filename #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaronjmars wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

fix(security): slugify entry_type before using it in the fabric filename #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions icarus/state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,10 +321,14 @@ def write_entry(entry_type, content, summary, tier="hot", tags="", platform="cli
suffix = secrets.token_hex(2)
# derive a short slug from the summary for human-readable filenames
slug = re.sub(r"[^a-z0-9]+", "-", summary.lower().strip())[:40].strip("-")
# entry_type is caller/tool-controlled and is used as a path component below;
# slugify it the same way as the summary so it can't introduce path separators
# or traversal sequences into the filename.
type_slug = re.sub(r"[^a-z0-9]+", "-", entry_type.lower().strip())[:32].strip("-") or "entry"
if slug:
filename = f"{agent}-{entry_type}-{slug}-{suffix}.md"
filename = f"{agent}-{type_slug}-{slug}-{suffix}.md"
else:
filename = f"{agent}-{entry_type}-{ts}-{suffix}.md"
filename = f"{agent}-{type_slug}-{ts}-{suffix}.md"

sid = session_id or os.environ.get(
"FABRIC_SESSION_ID", f"sess-{now.strftime('%Y%m%d-%H%M%S')}-{os.getpid()}")
Expand Down
Loading