Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKIP_DEFAULT_BACKGROUND #79243

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

SKIP_DEFAULT_BACKGROUND #79243

wants to merge 6 commits into from
+12 −8

Conversation

Maleclypse
Copy link
Member

@Maleclypse Maleclypse commented Jan 19, 2025 •
edited
Loading

Summary

Features "Skip Default Backgrounds"

Purpose of change

Churl in vanilla and several professions in mods shouldn't start with the modern adult hobby package.

Describe the solution

Adds flag and applies it

Describe alternatives you've considered

None

Testing

tbd

Additional context

@Maleclypse @RenechCDDA
SKIP_DEFAULT_BACKGROUND
b400a01 
Co-Authored-By: RenechCDDA <[email protected]>
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs Character / World Generation Issues and enhancements concerning stages of creating a character or a world Mods: Xedra Evolved Anything to do with Xedra Evolved astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jan 19, 2025
moxian
moxian reviewed Jan 19, 2025
View reviewed changes
src/newcharacter.cpp Outdated Show resolved Hide resolved
src/newcharacter.cpp Outdated Show resolved Hide resolved
doc/JSON/JSON_FLAGS.md Outdated Show resolved Hide resolved
@Maleclypse
Copy link
Member Author

@moxian thank you for your review! It had compiled so I've been testing and taking pictures of what's not working to look at tomorrow and then came here to find good news :)

@Maleclypse @github-actions
Update src/newcharacter.cpp
1505ae7 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions and removed astyled astyled PR, label is assigned by github actions labels Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moxian moxian moxian left review comments

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Character / World Generation Issues and enhancements concerning stages of creating a character or a world <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mods: Xedra Evolved Anything to do with Xedra Evolved Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maleclypse @moxian