Skip to content

Extract ClickPipes API models - #394

Merged
sdairs merged 2 commits into
issue-379-service-backup-postgres-modelsfrom
issue-381-clickpipes-api-models
Aug 13, 2026
Merged

Extract ClickPipes API models#394
sdairs merged 2 commits into
issue-379-service-backup-postgres-modelsfrom
issue-381-clickpipes-api-models

Conversation

@sdairs

@sdairs sdairs commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Closes #381

Summary

  • Extract the full ClickPipes CRUD, source, scaling, settings, state, schema-discovery, credential, and reverse-private-endpoint model surface.
  • Keep ClickPipes-owned credential and private-DNS leaves in the ClickPipes domain module.
  • Preserve all 221 relocated declarations/impls, public paths, Serde contracts, and analyzer inventory exactly.
  • Compile every ClickPipes integration target and add representative facade path coverage.

Tests

  • cargo fmt --all --check
  • cargo check --workspace --all-features
  • cargo test -p clickhouse-cloud-api -p clickhouse-openapi-analyzer
  • cargo clippy -p clickhouse-cloud-api -p clickhouse-openapi-analyzer --all-targets -- -D warnings

@sdairs
sdairs requested review from iskakaushik and rndD as code owners August 7, 2026 17:05
@sdairs
sdairs temporarily deployed to cloud-integration August 7, 2026 17:05 — with GitHub Actions Inactive
Comment thread crates/clickhouse-cloud-api/src/models/clickpipes.rs
Comment thread crates/clickhouse-cloud-api/src/models/clickpipes.rs
Comment thread crates/clickhouse-cloud-api/src/models/clickpipes.rs
Comment thread crates/clickhouse-cloud-api/src/models/clickpipes.rs

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the clickhouse-cloud-api crate by extracting the full ClickPipes model surface into a dedicated domain module while preserving the existing public API surface (api::… and api::models::…) and Serde/analyzer contracts.

Changes:

  • Added a new src/models/clickpipes.rs module containing the ClickPipes CRUD/source/scaling/settings/state/schema-discovery/credential/reverse-private-endpoint models.
  • Extended the model facade test to assert that key relocated ClickPipes types remain accessible via both root and models paths.

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

File Description
crates/clickhouse-cloud-api/tests/model_facade_test.rs Adds facade path/type-equality assertions for representative ClickPipes models.
crates/clickhouse-cloud-api/src/models/clickpipes.rs Introduces the extracted ClickPipes model surface in a dedicated models submodule.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@sdairs
sdairs force-pushed the issue-381-clickpipes-api-models branch from 19163ef to 6306c2a Compare August 8, 2026 18:37
@sdairs
sdairs temporarily deployed to cloud-integration August 8, 2026 18:37 — with GitHub Actions Inactive
@sdairs
sdairs temporarily deployed to cloud-integration August 8, 2026 19:04 — with GitHub Actions Inactive
@sdairs
sdairs force-pushed the issue-381-clickpipes-api-models branch from 6306c2a to 1694ff7 Compare August 13, 2026 11:37
@sdairs
sdairs had a problem deploying to cloud-integration August 13, 2026 11:38 — with GitHub Actions Failure
@sdairs
sdairs had a problem deploying to cloud-integration August 13, 2026 11:45 — with GitHub Actions Failure
@sdairs
sdairs force-pushed the issue-381-clickpipes-api-models branch from 1694ff7 to e45447a Compare August 13, 2026 18:29

@iskakaushik iskakaushik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdairs
sdairs merged commit faf940a into main Aug 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extract ClickPipes API models

3 participants