Extract ClickPipes API models - #394
Merged
sdairs merged 2 commits intoAug 13, 2026
Merged
Conversation
sdairs
temporarily deployed
to
cloud-integration
August 7, 2026 17:05 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the clickhouse-cloud-api crate by extracting the full ClickPipes model surface into a dedicated domain module while preserving the existing public API surface (api::… and api::models::…) and Serde/analyzer contracts.
Changes:
- Added a new
src/models/clickpipes.rsmodule containing the ClickPipes CRUD/source/scaling/settings/state/schema-discovery/credential/reverse-private-endpoint models. - Extended the model facade test to assert that key relocated ClickPipes types remain accessible via both root and
modelspaths.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/clickhouse-cloud-api/tests/model_facade_test.rs | Adds facade path/type-equality assertions for representative ClickPipes models. |
| crates/clickhouse-cloud-api/src/models/clickpipes.rs | Introduces the extracted ClickPipes model surface in a dedicated models submodule. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sdairs
force-pushed
the
issue-381-clickpipes-api-models
branch
from
August 8, 2026 18:37
19163ef to
6306c2a
Compare
sdairs
temporarily deployed
to
cloud-integration
August 8, 2026 18:37 — with
GitHub Actions
Inactive
sdairs
temporarily deployed
to
cloud-integration
August 8, 2026 19:04 — with
GitHub Actions
Inactive
sdairs
force-pushed
the
issue-381-clickpipes-api-models
branch
from
August 13, 2026 11:37
6306c2a to
1694ff7
Compare
sdairs
had a problem deploying
to
cloud-integration
August 13, 2026 11:38 — with
GitHub Actions
Failure
sdairs
had a problem deploying
to
cloud-integration
August 13, 2026 11:45 — with
GitHub Actions
Failure
sdairs
force-pushed
the
issue-381-clickpipes-api-models
branch
from
August 13, 2026 18:29
1694ff7 to
e45447a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #381
Summary
Tests
cargo fmt --all --checkcargo check --workspace --all-featurescargo test -p clickhouse-cloud-api -p clickhouse-openapi-analyzercargo clippy -p clickhouse-cloud-api -p clickhouse-openapi-analyzer --all-targets -- -D warnings