Extract ClickStack scalar enums - #395
Merged
sdairs merged 1 commit intoAug 13, 2026
Merged
Conversation
sdairs
temporarily deployed
to
cloud-integration
August 7, 2026 17:17 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extracts the ClickStack scalar enum vocabulary out of the models.rs facade into a dedicated models/clickstack_enums.rs module, while preserving the existing public re-export paths (clickhouse_cloud_api::... and clickhouse_cloud_api::models::...) and keeping enum wire values/catch-alls intact.
Changes:
- Introduces
src/models/clickstack_enums.rscontaining the extracted ClickStack scalar enums (including theirDisplay/Defaultbehavior and unknown-value catch-alls). - Wires the new module into
src/models.rsviamod clickstack_enums;andpub use clickstack_enums::*;, removing the inlined enum block from the facade. - Extends the model facade path-stability test to cover
ClickStackChartColoras a representative ClickStack enum.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/clickhouse-cloud-api/src/models/clickstack_enums.rs | New module holding extracted ClickStack scalar enums and their implementations. |
| crates/clickhouse-cloud-api/src/models.rs | Registers + re-exports the new module and removes the extracted inline enum definitions. |
| crates/clickhouse-cloud-api/tests/model_facade_test.rs | Adds an assertion that ClickStackChartColor keeps identical root vs models:: paths. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sdairs
force-pushed
the
issue-378-clickstack-enums
branch
from
August 8, 2026 18:37
0bbcbe9 to
c662ade
Compare
sdairs
temporarily deployed
to
cloud-integration
August 8, 2026 18:37 — with
GitHub Actions
Inactive
sdairs
had a problem deploying
to
cloud-integration
August 8, 2026 19:01 — with
GitHub Actions
Failure
sdairs
force-pushed
the
issue-378-clickstack-enums
branch
from
August 13, 2026 11:37
c662ade to
aeef35d
Compare
sdairs
had a problem deploying
to
cloud-integration
August 13, 2026 11:38 — with
GitHub Actions
Failure
sdairs
had a problem deploying
to
cloud-integration
August 13, 2026 11:48 — with
GitHub Actions
Failure
sdairs
force-pushed
the
issue-378-clickstack-enums
branch
from
August 13, 2026 18:29
aeef35d to
2081f74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #378
Summary
Tests
cargo fmt --allcargo check --workspace --all-featurescargo test -p clickhouse-cloud-api -p clickhouse-openapi-analyzercargo clippy -p clickhouse-cloud-api -p clickhouse-openapi-analyzer --all-targets -- -D warnings