Extract remaining ClickStack API models and finalize the library split - #396
Conversation
|
Macroscope skipped reviewing this pull request. Per-review cost limit exceeded (workspace setting). This review would cost an estimated $10.49, which exceeds your per-review limit of $10.00. The top 3 files driving up this estimate:
Tip To get this pull request reviewed, you can:
|
There was a problem hiding this comment.
Pull request overview
This PR completes the clickhouse-cloud-api model split by moving the remaining ClickStack model surface out of the src/models.rs monolith into a dedicated private domain module, while preserving the existing public import paths and updating contributor documentation to reflect the final per-domain layout and analyzer traversal behavior.
Changes:
- Added a
clickstackdomain module undersrc/models/and re-exported it from themodels.rsfacade to keepcrate_root::*andmodels::*paths stable. - Extended the facade regression test to include
ClickStackDashboardResponsein both crate-root andmodels::*paths. - Updated
crates/clickhouse-cloud-api/README.mdandAGENTS.mdto document the per-domain file layout and the analyzer’s recursive module-tree traversal (and clarified the no-#[serde(default)]tolerance policy).
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/clickhouse-cloud-api/tests/model_facade_test.rs | Adds a regression assertion that the extracted ClickStack dashboard response type remains available via both crate-root and models::* paths. |
| crates/clickhouse-cloud-api/src/models.rs | Introduces the clickstack module and re-export, continuing the facade-only models.rs structure with shared macro support. |
| crates/clickhouse-cloud-api/README.md | Updates library structure + optionality/tolerance documentation to match the final split (src/models/*.rs, src/client/*.rs, src/convert/*.rs). |
| AGENTS.md | Updates contributor guidance to the finalized per-domain layout and analyzer traversal expectations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
763fa4a to
604a916
Compare
604a916 to
174ebdc
Compare
174ebdc to
d505f20
Compare
Closes #376
Summary
models.rsto a 251-line private-module facade while preserving all crate-root andmodels::*paths.Tests
cargo fmt --all --checkcargo test -p clickhouse-cloud-api -p clickhouse-openapi-analyzercargo clippy -p clickhouse-cloud-api -p clickhouse-openapi-analyzer --all-targets -- -D warningscargo check --workspace --all-featurespython3 -m unittest discover -s scripts/tests -p 'test_*.py'\n-python3 scripts/check-openapi-drift.py --dry-run(12 unrelated live upstream findings; no ClickStack findings)