Extract the ClickPipes clap contract and parsing tests - #401
Merged
Conversation
sdairs
had a problem deploying
to
cloud-integration
August 7, 2026 21:57 — with
GitHub Actions
Failure
sdairs
temporarily deployed
to
cloud-integration
August 7, 2026 22:18 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the ClickPipes CLI surface by relocating the entire ClickPipes clap contract (subcommands, argument structs, accepted-value sets, and parsing/write-classification tests) into a dedicated cloud::clickpipes domain module, while preserving the existing crate::cloud::cli::* public paths via re-exports.
Changes:
- Added a new
crates/clickhousectl/src/cloud/clickpipes.rsmodule containing all ClickPipes clap enums/args, possible-value constants, and adjacent parsing + write-classification tests. - Updated
cloud::clito re-export the moved ClickPipes types and to delegateCloudCommands::is_write_command()ClickPipe classification toClickPipeCommands::is_write(). - Wired the new module into
cloud/mod.rsso the domain module is compiled and available for the existing re-export surface.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/clickhousectl/src/cloud/mod.rs | Registers the new clickpipes module in the cloud domain. |
| crates/clickhousectl/src/cloud/clickpipes.rs | New ClickPipes clap contract + exhaustive parsing/write-classification tests colocated with the definitions. |
| crates/clickhousectl/src/cloud/cli.rs | Re-exports ClickPipes types from the new module and simplifies write-classification by delegating to ClickPipeCommands::is_write(). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sdairs
force-pushed
the
issue-386-clickpipes-clap
branch
from
August 8, 2026 18:37
2d1383a to
7bf0690
Compare
sdairs
had a problem deploying
to
cloud-integration
August 8, 2026 18:37 — with
GitHub Actions
Failure
sdairs
temporarily deployed
to
cloud-integration
August 8, 2026 18:45 — with
GitHub Actions
Inactive
sdairs
force-pushed
the
issue-386-clickpipes-clap
branch
from
August 13, 2026 11:37
7bf0690 to
21971fa
Compare
sdairs
had a problem deploying
to
cloud-integration
August 13, 2026 11:38 — with
GitHub Actions
Failure
sdairs
had a problem deploying
to
cloud-integration
August 13, 2026 11:45 — with
GitHub Actions
Failure
sdairs
force-pushed
the
issue-386-clickpipes-clap
branch
from
August 13, 2026 18:29
21971fa to
dca826a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #386
Summary
cloud::cli::*re-exports.Tests
cargo fmt --allcargo check --workspace --all-featurescargo test -p clickhousectlcargo clippy -p clickhousectl --all-targets -- -D warnings