Skip to content

Validate PostgreSQL ClickPipe inputs before Cloud API dispatch - #484

Closed
sdairs wants to merge 13 commits into
issue-454-repair-query-keyfrom
issue-449-postgres-clickpipe-validation
Closed

Validate PostgreSQL ClickPipe inputs before Cloud API dispatch#484
sdairs wants to merge 13 commits into
issue-454-repair-query-keyfrom
issue-449-postgres-clickpipe-validation

Conversation

@sdairs

@sdairs sdairs commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • validate PostgreSQL ClickPipe ports, required and non-empty table mappings, IAM role authentication, and replication-slot mode before Cloud API access
  • extract a typed PostgreSQL request builder while preserving valid basic-auth cdc, snapshot, and cdc_only request shapes
  • cover clap parsing, minimal/maximal typed requests, certificate and destination fields, and subprocess no-dispatch behavior

Verification

  • cargo test -p clickhousectl cloud::clickpipes::tests (43 passed)
  • cargo test -p clickhousectl --test cli_request_shape_test postgres_ (23 passed)
  • cargo fmt --all --check
  • cargo build -p clickhousectl
  • cargo test -p clickhousectl (744 passed)
  • cargo clippy -p clickhousectl --all-targets -- -D warnings

Stack

Position: 1 of 1, targeting main (bottom and top).

Closes #449

@sdairs sdairs changed the title issue 449 postgres clickpipe validation Validate PostgreSQL ClickPipe inputs before Cloud API dispatch Aug 24, 2026
@sdairs
sdairs force-pushed the issue-449-postgres-clickpipe-validation branch from 5b737ac to 8be9820 Compare August 25, 2026 12:11
@sdairs
sdairs changed the base branch from main to issue-454-repair-query-key August 25, 2026 12:13

@iskakaushik iskakaushik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdairs
sdairs force-pushed the issue-454-repair-query-key branch from 93f7466 to ce10368 Compare August 25, 2026 21:55
@sdairs

sdairs commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by #539 in stack #563.

@sdairs sdairs closed this Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate PostgreSQL ClickPipe inputs before Cloud API dispatch

2 participants