Preserve native query and query-file multiplicity in local client - #506
Closed
sdairs wants to merge 13 commits into
Closed
Preserve native query and query-file multiplicity in local client#506sdairs wants to merge 13 commits into
sdairs wants to merge 13 commits into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 133d21b. Configure here.
sdairs
force-pushed
the
issue-469-direct-client-version
branch
from
August 25, 2026 12:11
15418a6 to
ffaf4cb
Compare
sdairs
force-pushed
the
issue-470-local-client-query-multiplicity
branch
from
August 25, 2026 12:11
133d21b to
6774653
Compare
sdairs
force-pushed
the
issue-469-direct-client-version
branch
from
August 25, 2026 22:01
30c6f10 to
67fbcf3
Compare
Collaborator
Author
|
Superseded by #553 in stack #563. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
--queryvalue and forward each as a native query option in source order--queries-filepaths, including repeated wrapper flags, and emit the native multi-path argv shapeCloses #470
Decision
Native source for 25.8.32.4 LTS, 25.12.9.61, 26.3.21.7 LTS, 26.7.5.10 stable, and current master uses a repeatable query vector, a multi-token queries-file vector, and rejects the two source types together. The wrapper therefore emits repeated
--querypairs, emits one--queries-filefollowed by every path, and rejects combined forms before resolution or child execution. The JSON output contract in #468 remains unchanged.Verification
cargo fmt --all --checkcargo build -p clickhousectlcargo test -p clickhousectl(762 passed)cargo clippy -p clickhousectl --all-targets -- -D warnings--pass-through forms across the existing 25.x and 26.x client-version fixturesStack
issue-469-direct-client-version)