Skip to content

Expose project scope in managed local client errors - #518

Closed
sdairs wants to merge 4 commits into
issue-477-server-project-scope-errorsfrom
issue-467-client-project-scope-errors
Closed

Expose project scope in managed local client errors#518
sdairs wants to merge 4 commits into
issue-477-server-project-scope-errorsfrom
issue-467-client-project-scope-errors

Conversation

@sdairs

@sdairs sdairs commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • identify managed local client mode and the canonical current project directory for missing, stopped, and missing-binary failures
  • preserve inherited structured error codes while adding safe mode and project fields, concise human guidance, and fixed recovery commands
  • cover exact-directory lookup, including empty projects, child directories, explicit names, stopped metadata, and telemetry redaction

Closes #467

Tests

  • cargo fmt --all --check
  • cargo build -p clickhousectl
  • cargo check -p clickhousectl --no-default-features
  • cargo test -p clickhousectl (636 unit tests plus all integration suites)
  • cargo clippy -p clickhousectl --all-targets -- -D warnings
  • cargo clippy -p clickhousectl --no-default-features --all-targets -- -D warnings

Stack

Comment thread crates/clickhousectl/src/local/mod.rs Outdated
@sdairs
sdairs changed the base branch from issue-472-atomic-server-metadata to issue-477-server-project-scope-errors August 24, 2026 21:37
@sdairs sdairs changed the title issue 467 client project scope errors Expose project scope in managed local client errors Aug 24, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1eb8e3e. Configure here.

Comment thread crates/clickhousectl/src/local/mod.rs
@sdairs
sdairs force-pushed the issue-477-server-project-scope-errors branch from d3c7ff9 to e1dbf66 Compare August 25, 2026 12:11
@sdairs
sdairs force-pushed the issue-467-client-project-scope-errors branch from c12947b to 073bfa0 Compare August 25, 2026 12:11

@iskakaushik iskakaushik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdairs

sdairs commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by #558 in stack #563.

@sdairs sdairs closed this Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make local client managed-state errors explain project scope

2 participants