Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Symbolic outputs of tendencies #31

Merged
merged 148 commits into from
Mar 12, 2025
Merged

Feature: Symbolic outputs of tendencies #31

merged 148 commits into from
Mar 12, 2025

Conversation

jodemaey
Copy link
Member

No description provided.

ushham added 30 commits July 6, 2023 17:39
@ushham
Symbolic Outputs branch - new parameter dict & symbolic tensor
43e94db
@ushham
Working symbolic parameters
2e8b461
@ushham
Update to ip - working for symbolic, broken the numeric
e1d6d5d
@ushham
Ocean symbolic ip updated
eec1dd8
@ushham
Ground symbolic ip updated
0e8b1c7
@ushham
working symbolic ip - not tested
7b01564
@ushham
Symbolic tensor DE started - not working
d554839
@ushham
Update to parameter locations
07518fa
@ushham
edit to subs in IP
e02720f
@ushham
Bug fixing the symbolic tensor
0573894
@ushham
working out a way to take tensor products
d85c1da
@ushham
Addition of tensordot and calculating inverse matricies properly
2963976
@ushham
Update of addition to dict
411cb28
@ushham
using tensorproduct in all calculations
7f3728e
@ushham
Rough draft of dynT
7d583ee
@ushham
Addition of useful functions
f64422b
@ushham
Changing the way subs work in IP
b600ad5
@ushham
Edits to the way printing of the tensor works
cb29fd4
@ushham
change to definition of n in basis
9b618f9
@ushham
First working symbolic tensor - outputs incorrect4
7e658f6
@ushham
Fix of sign errors - Stored Linear Tensor checked for atm-ocn
a8903d0
@ushham
Edit to functions to allow them to work with tensors of any rank
046cadc
@ushham
Bugs in DE tensor calc fixes
5b5a39f
@ushham
Update to dynamic_T loop for speed
20da196
@ushham
cleaning up the file
7005af0
@ushham
notebooks used to test tensor
222fc0a
@ushham
Update to do all calculations using dictionaries not symbolic tensors
5012c93
@ushham
issue with DE qg tensor - not fixed
ce956d0
@ushham
Edit to structure of additional functions
f509edf
@ushham
Dyn T tensor working - output of results draft
3d094dc
ushham added 15 commits February 15, 2024 19:25
@ushham
Merge remote-tracking branch 'refs/remotes/origin/feature/symbolic_ou…
36bd031 
…tputs' into feature/symbolic_outputs
@ushham
Symbolic tensor contraction bug fix
2445742
@ushham
Correction of bugs in symbolic dynT - Tests not passing yet
27763d3
@ushham
Fix of missue of 'connect_to_ocean' in test
e614e6d
@ushham
Clean up of function outputs - Tests passing
55f0882
@ushham
Cleanup of notebook
02d4bf6
@ushham
Symbolic outputs documentation
2ce9cd0
@ushham
intro notebook added
17c8033
@ushham
Bug fix - ground modes
af6c51d
@ushham
Inclusion of translating final outputs - bug found where EPSILON was …
75d9a23 
…included in fortran output
@ushham
removal of rogue print statement
f093252
@ushham
Working function translation - fortran EPSILON bug fix
f420fe7
@ushham
Bug fix - replacing of strings before eq is split across rows - fortr…
ffbbb89 
…an version
@ushham
Replacing lambda string in python symbolic outputs
157905c
@ushham
Bug fix in non-stored symbolic tensor
3da2ff5
@jodemaey
Copy link
Member Author

Hi @ushham ,

I have created this PR because we need to move on with the symbolic outputs.
There is a merge conflict, but it is not a big deal (it is in a docstring).

How I see this evolves is that we still clean some stuffs (mainly notebooks and tests), then we merge this PR.
Then we start a new branch to document the new functionalities in the doc.

See you soon to discuss this.

J.

@jodemaey
Copy link
Member Author

jodemaey commented Mar 11, 2025 •
edited
Loading

Hi @ushham ,

So I have deleted the old notebooks and created 2 new ones in the notebooks/symbolic_outputs folder.
Please check them. Also I resolved the merge conflict.

A problem remains with the tests. They are not passing and I think I know why, and we should discuss that asap. Then I think you should review one last time and we can merge.

J.

@jodemaey jodemaey requested a review from ushham March 12, 2025 10:13
ushham
ushham reviewed Mar 12, 2025
View reviewed changes
Copy link
Collaborator

@ushham ushham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the version number in the toml file?

@jodemaey
Copy link
Member Author

Not yet. This is not the final PR before the release.

ushham
ushham approved these changes Mar 12, 2025
View reviewed changes
Copy link
Collaborator

@ushham ushham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, this looks good to me

@jodemaey jodemaey merged commit 72564aa into develop Mar 12, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ushham ushham ushham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jodemaey @ushham