fix: restore proper deprecation for database_less configuration #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The database_less configuration option was removed in v9.1.0 without proper deprecation, causing deployments to fail when upgrading if they had this configuration in their production.rb or initializers. This change restores backward compatibility by: - Adding a minimal Configuration class that captures the deprecated database_less option - Showing specific deprecation warnings when database_less is used - Making the option a no-op (always returns false) since it's no longer needed - Providing clear migration guidance for users to remove their configuration The deprecation timeline indicates removal in v10.0.0, giving users time to migrate away from this obsolete configuration without breaking deployments. Also includes improvements to HasClosureTree include order dependency and README formatting fixes to use inline return value comments. Fixes the missing deprecation that was introduced when migrating to Zeitwerk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Restores proper deprecation for the
database_lessconfiguration option that was removed in v9.1.0 without deprecation, causing deployment failures for users who had this configuration in their production setup.Changes Made
Configurationclass to handle the deprecated option with proper warningsClosureTree.configureto show specific deprecation messagesAssociationSetupconcernacts_as_treealias to prevent conflicts with other gemsBreaking Change Fix
This addresses the breaking change introduced in v9.1.0 where users with existing configuration would see deployment failures. Now they get proper deprecation warnings:
The option will be completely removed in v10.0.0.