Skip to content

Fix snapshot pagination bug #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix snapshot pagination bug #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a08896b
Fix hasNextPage bug in snapshot
majecty Apr 22, 2020
065675c
Parse lastEvaluatedKey in snapshot query
majecty Apr 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/models/logic/utxo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,8 +506,7 @@ export async function getSnapshot(params: {
transaction,
type: sequelize.QueryTypes.SELECT
}
)).count ===
itemsPerPage + 1;
)).count === String(itemsPerPage + 1);

// The SQL query is copied from the query above.
const lastRow = await models.sequelize.query(
Expand Down
5 changes: 4 additions & 1 deletion src/routers/asset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,10 @@ export function handle(context: IndexerContext, router: Router) {
async (req, res, next) => {
const assetTypeString = req.query.assetType;
const date = req.query.date;
const lastEvaluatedKey = req.query.lastEvaluatedKey;
let lastEvaluatedKey = req.query.lastEvaluatedKey;
if (typeof lastEvaluatedKey === "string") {
lastEvaluatedKey = JSON.parse(lastEvaluatedKey);
}
try {
const assetType = new H160(assetTypeString);
const snapshotTime = moment(date);
Expand Down