Language server installation menu #1997
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FastestMolasses
added
enhancement
| print("Installing \(source.name)@\(source.version) in \(packagePath.path)") | ||
|
|
||
| do { | ||
| var cargoArgs = ["cargo", "install", "--root", "."] |
There was a problem hiding this comment.
What happens when the dev tooling is not installed on the system?
There was a problem hiding this comment.
The initialize function in each of these package managers will first check if the tool is installed and if not, a PackageManagerError.packageManagerNotInstalled error will get thrown and then displayed on the UI
| import ZIPFoundation | ||
|
|
||
| final class RegistryManager { | ||
| static let shared: RegistryManager = .init() |
There was a problem hiding this comment.
Everytime shared is called a new instance is created? Is that the idea or..?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A system to allow users to download and manage LSP servers from the settings menu. This utilizes the mason registry to track the language servers.
Related Issues
Checklist
Screenshots