-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Live Preview #2150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Live Preview #2150
Conversation
|
Looks good! Can the user toggle this preview open or closed? Can this panel be resized? |
No to both but I can add that |
Update:
Screen RecordingScreen.Recording.2025-12-10.at.10.49.24.PM.mov |
wjk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I fixed the warnings it should pass the SwiftLint check |
|
How do you open and close the preview pane? Resizing looks a big choppy. |
There is a eye icon in the middle of the editor to open it. but when the preview is open there's a gray icon on the top right seen in my second screen recording and I'll smooth out the sliding once my practice is over |
wjk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Related Issues
Checklist
Will eventually work on markdown preview
I read and understood the contributing guide as well as the code of conduct
The issues this PR addresses are related to each other
My changes generate no new warnings
My code builds and runs on my machine
My changes are all related to the related issue above
I documented my code
Screenshots
Screen.Recording.2025-12-02.at.9.21.18.PM.mov