Repository navigation
fix(api): keep the port in the GitHub OAuth callback URL - #222
Merged
Merged
Conversation
`request.hostname` strips the port, so an instance on anything but 80/443 sent GitHub a redirect_uri of `http://localhost/api/auth/github/callback` and the round-trip failed with a redirect_uri mismatch — local dev on :3001 and the devbox test instance on :3100 both hit it. `request.host` keeps the port; the X-Forwarded-Host path behind the gateway is unchanged. Test covers both. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TGqwPjt3v4eMfiHpPmCKnR
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
request.hostnamestrips the port, so any instance not on 80/443 sent GitHub aredirect_uriwithout it (http://localhost/api/auth/github/callbackfor local dev on :3001) and the OAuth round-trip failed with a redirect_uri mismatch. Found standing up the devbox test instance on :3100.request.hostkeeps the port; theX-Forwarded-Host/X-Forwarded-Protopath used behind the gateway is unchanged. The new test covers both the direct and the proxied case.🤖 Generated with Claude Code
https://claude.ai/code/session_01TGqwPjt3v4eMfiHpPmCKnR