Maybe done? #48
Open
Maybe done? #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Want to see if I'm getting 0.0 and it's just not showing.
Trying to avoid fatal error. Seeing if I can check each problem singly as I go.
Added a space after the comma to see if that was what was creating the error. Error read: DataTypesTest::testConvertToString with data set CodeLouisville#6 (array(2, 3), '2, 3') Failed asserting that two strings are identical.
Added part to pass through array if it already exists as an array.. Took
our str_split for strings and floats and changed to array_map('strval',
array($arrgh)
Simplified code - took out conditionals. Checking to see if the null value converts to an empty array
Checking for errors.
Went back to previous version of convert_to_array
Author
|
Woot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How's array code