Skip to content

increase supported django version to < 5 - #25

Open
tiholic wants to merge 1 commit into
CodeYellowBV:masterfrom
tiholic:master
Open

increase supported django version to < 5#25
tiholic wants to merge 1 commit into
CodeYellowBV:masterfrom
tiholic:master

Conversation

@tiholic

@tiholic tiholic commented Mar 22, 2022

Copy link
Copy Markdown
Contributor

Increase django supported version from < 4 to < 5

Note: prefer squash and merge on this PR please :)

fix deprecation warning for `ugettext_lazy` and update django supported version
@chris-umed

Copy link
Copy Markdown

@sjamaan @ashishnitinpatil @emanuelmd @mkay849 - will this be merged soon? It is now a blocker for our project and would prefer not to have to fork your project just for this.

@ashishnitinpatil

Copy link
Copy Markdown
Contributor

This should ideally be tested for django version 4. The project has a tox.ini which should be updated along with the requirements change and well, tested. I do not maintain the library so have no permissions to merge or release.

@sjamaan

sjamaan commented Aug 11, 2022

Copy link
Copy Markdown
Contributor

This should ideally be tested for django version 4. The project has a tox.ini which should be updated along with the requirements change and well, tested. I do not maintain the library so have no permissions to merge or release.

Unfortunately, I don't work with Django anymore at the moment and I won't have the time to maintain this library. Perhaps @abzainuddin can have a look - the change LGTM at least, although the gettext suppression seems to have disappeared? I'd suggest at least changing the commit message before merging.

@uhurusurfa

uhurusurfa commented Aug 11, 2022

Copy link
Copy Markdown

Given Django 2 is no longer officially supported and it creates complications to support v2 and v4, Django 2 should no longer be supported and users stil on Django 2 can download the current released version.
A PR will be raised shortly that implements github actions to run the tox tests and supports Django 4 by @martin-marty

@sevdog sevdog mentioned this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants