Glasgow 06 - Malkit Benning - Full Stack Project Assessment - Level 300 complete #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added lighthouse results as saved html file
malkitbenning
changed the title
AightA
reviewed
Aug 24, 2023
client/src/MovieCard.js
Outdated
| @@ -0,0 +1,70 @@ | |||
| import React from "react"; | |||
| import "./MovieCard.css"; | |||
| function MovieCard(props) { | |||
There was a problem hiding this comment.
you could deconstruct your props in side as in function MovieCard({ movie, setRefreshVideos})
for the key, technically you are passing in movie therefore inside that you've got movie.id.
give it a try and let's see.
client/src/MovieCard.js
Outdated
| import "./MovieCard.css"; | ||
| function MovieCard(props) { | ||
| const fetchAddress = "https://full-stack-server-fofh.onrender.com/"; | ||
| const movieName = props.movie.url.split("watch?v=")[1]; |
There was a problem hiding this comment.
then any props you simply used directly, therefore remove all props from props.movie.url into movie.url
client/src/MovieCard.js
Outdated
| } | ||
|
|
||
| function upVote() { | ||
| let newVote = props.movie.rating + 1; |
There was a problem hiding this comment.
i'd change this to const. same as downVote
| import React, { useState } from "react"; | ||
| import "./NewVideoContainer.css"; | ||
|
|
||
| function NewVideoContainer({ allMovies, setRefreshVideos }) { |
client/src/NewVideoContainer.js
Outdated
| const [newTitle, setNewTitle] = useState(""); | ||
| const [newURL, setNewURL] = useState(""); | ||
| function addNewVideo() { | ||
| console.log("button clicked"); |
There was a problem hiding this comment.
is this needed here ? usually don't leave console.logs as they can cause security vulnerabilities.
| let newRating = 0; | ||
|
|
||
| client | ||
| .query("INSERT INTO videos (id, title, url, rating) VALUES ($1, $2, $3, $4)", [newId, newTitle, newUrl, newRating]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React app deployed on netlify, server and database on Render. All working - rating updates, adding new videos and deleting from database via calls from netlify app then server.
Added both client and server code into one branch too allow me to run both locally and edit files at the same time.
Code now includes sql calls and also use of env variables so no passwords or database details are accidentally leaked.