GLASGOW6_IRIANNI-MUNOZ_FULL-STACK-ASSESSMENT #361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bringing all my changes into main
Adding video feature working
DELETE method implemented and working
GET by ID method implemented
Fixing POST method, it's working now
Rendering all videos from local API Installed CORS packaged so the videos would render
Level 250 finished
Connecting db with node Fixing node_modules problem
|
Hello @munozirianni1988, Thank you for your submission - I can see lots of good commits in your version history! Please could you also share a link to the deployed version of your app so I can check it works properly too - I can only review your source code at the moment. Thankyou! |
useEffect had a missing dependency, causing the component to re render, so I wrapped the fetchVideo function in a useCallback so I could included on the dependency array and fix the warning
Hi! Thanks for checking my submission. Hee is the link for my deployment link: https://irianni-fsa-frontend.onrender.com |
ali-nasir-ali
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Level 100