Glasgow 6 | Haroun Alarabi | Full-Stack-Project-Assessment | Level 300 #393

HarounAlarabi · 2023-09-03T17:58:54Z

https://verdant-crisp-d6d210.netlify.app/
Hi @Dedekind561 I'm attempting to display data from Render in browser but i's not showing up. However, when I use Postman to retrieve the data from Render, it works as expected."

Dedekind561 · 2023-09-12T15:03:52Z

Hi @HarounAlarabi ,
Thankyou for submitting Level 300 of the Full Stack Project Assessment. However, at the moment, I can't review your work properly. Locally I'm just seeing a blank screen with a heading Video Recommendation - do you have a deployed version of the site itself?

Dedekind561 · 2023-09-16T07:18:28Z

Morning Haroun,
Thankyou for submitting a link to your deployed application.
At the moment, I can't review your work because you've committed the node_modules. Please can you remove them from your pull request then I can take a look :)

Dedekind561 · 2023-09-16T07:18:55Z

The deployed version of your app is now working for me at the moment :)

HarounAlarabi · 2023-09-16T10:49:01Z

Hi @Dedekind561 I have commited the code again with changes

Dedekind561

Hi Haroun,
Thanks for your submission,
I've just taken a look at your code.
The deployed application has the core functionality; however, you need to look more carefully at your logic when adding a new video. Think carefully how the state of your application updates after you've made the POST request. Write down the steps on your piece of paper and think about it carefully to see if you can identify the issues.

Well done on your work so far though 🎉

Dedekind561 · 2023-09-16T12:22:40Z

client/src/components/AddVideo.jsx

+        rating: 0,
+      };
+
+      onVidAdd(newInput);


Unclear to me what this function does just by reading its name onVidAdd

Dedekind561 · 2023-09-16T12:23:56Z

client/src/components/VideosList.jsx

+  const [searchResult, setSearchResult] = useState([]);
+
+  useEffect(() => {
+    fetch("https://node-server-full-stack.onrender.com/videos")


Use an environment variable for this API url - don't just hardcode the string. Do you understand why this is important?

I chaned this

Dedekind561 · 2023-09-16T12:26:20Z

server/DBConfig.js

@@ -0,0 +1,8 @@
+const { Pool } = require("pg");
+const videosPool = new Pool({
+  connectionString: "postgres://full_stack_database_jp62_user:JfOA8mzl7maxtJEnTL28nmslJ5JSqVfe@dpg-ck2p2hvqj8ts73fm2m5g-a.oregon-postgres.render.com/full_stack_database_jp62",


❗ You've just made your database connection string public! You need to store strings like this in env variables 👀

I have tried before to use variables to store it but I got an error then I used this way

Dedekind561 · 2023-09-16T12:27:30Z

client/src/index.css

+
+form{
+margin: 20px;
+max-width: 400px;


This CSS rule isn't indented properly: how can you fix this 🔨 ?

Dedekind561 · 2023-09-16T12:34:37Z

client/src/components/VideosList.jsx

+      .then((res) => res.json())
+      .then((data) => {
+        setVideos(data);
+        searchResult(data);


Here you're fetching the data and then you

call res.json()

call setVideos with the data

and then call searchResult -> can you explain the issue here?

the issue here is I used searchResult , so I have to change in to setSearchResult()

Dedekind561 · 2023-09-16T12:42:57Z

client/src/components/VideosList.jsx

+      body: JSON.stringify(newInput),
+    })
+      .then((res) => {
+        fetchVideos();


Call to fetchVideos here - describe the effect of calling this function here

fetchVideos to update the list of videos after adding new video

Dedekind561 · 2023-09-16T12:44:27Z

client/src/components/VideosList.jsx

+        return res.json();
+      })
+      .then((data) => {
+        if (data && data.message === "Video stored successfully") {


Now you're calling setVideos down here as well - I think you need to think very carefully about what happens when after you've POSTed a new video to your database

Signed-off-by: Haroun Alarabi <[email protected]>

…ack-Project-Assessment into Level--300

Signed-off-by: Haroun Alarabi <[email protected]>

…ack-Project-Assessment into Level--300

Signed-off-by: Haroun Alarabi <[email protected]>

HarounAlarabi added 6 commits August 15, 2023 17:24

level 100

69edd6a

updated 199

1bf955f

level 300

8e17e0a

installed pg

c6a5a26

remove node -module

31714ca

add git ignore

11db4a6

Dedekind561 added the in progress Mentor review in progress label Sep 12, 2023

HarounAlarabi added 6 commits September 12, 2023 22:19

update server

f430199

fixed server

5a65a94

update fetch adresses

f1719dd

update fetch adresses

9b6119d

Create settings.json

c9b4d77

update fetch adresses

2a5c39b

update fetch adresses

e03cf78

HarounAlarabi added 2 commits September 16, 2023 12:16

updated delete function

693fca6

updated data base link

617033c

Dedekind561 reviewed Sep 16, 2023

View reviewed changes

HarounAlarabi and others added 9 commits January 26, 2024 19:16

update date base

bf67c03

added aws server and database

47555fc

remove build

e9264f8

Update Video.jsx

4c0da5a

Update Video.jsx

9f9b409

Signed-off-by: Haroun Alarabi <[email protected]>

Update package.json

1520c40

Signed-off-by: Haroun Alarabi <[email protected]>

Create frontend-s3-deploy.yml

f2cda8e

Signed-off-by: Haroun Alarabi <[email protected]>

Update frontend-s3-deploy.yml

aef98ae

Signed-off-by: Haroun Alarabi <[email protected]>

Update frontend-s3-deploy.yml

320d332

Signed-off-by: Haroun Alarabi <[email protected]>

HarounAlarabi and others added 29 commits February 13, 2024 15:40

Update backend-ec2-deploy.yml

ba46007

Signed-off-by: Haroun Alarabi <[email protected]>

Update backend-ec2-deploy.yml

1f540b3

Signed-off-by: Haroun Alarabi <[email protected]>

Update backend-ec2-deploy.yml

54fb352

Signed-off-by: Haroun Alarabi <[email protected]>

Update backend-ec2-deploy.yml

1c5bd0f

Signed-off-by: Haroun Alarabi <[email protected]>

Update backend-ec2-deploy.yml

45b4590

Signed-off-by: Haroun Alarabi <[email protected]>

Update backend-ec2-deploy.yml

d2297a6

Signed-off-by: Haroun Alarabi <[email protected]>

Update backend-ec2-deploy.yml

add2bb1

Signed-off-by: Haroun Alarabi <[email protected]>

Update backend-ec2-deploy.yml

3cd0fa9

Signed-off-by: Haroun Alarabi <[email protected]>

Update backend-ec2-deploy.yml

11347fc

Signed-off-by: Haroun Alarabi <[email protected]>

Update backend-ec2-deploy.yml

8df7ad8

Signed-off-by: Haroun Alarabi <[email protected]>

Update backend-ec2-deploy.yml

abca632

Signed-off-by: Haroun Alarabi <[email protected]>

Update backend-ec2-deploy.yml

41ad17d

Signed-off-by: Haroun Alarabi <[email protected]>

Update backend-ec2-deploy.yml

25f60e4

Signed-off-by: Haroun Alarabi <[email protected]>

Update backend-ec2-deploy.yml

7bfd385

Signed-off-by: Haroun Alarabi <[email protected]>

added docker file

a869b0d

Merge branch 'Level--300' of https://github.com/HarounAlarabi/Full-St…

41a2720

…ack-Project-Assessment into Level--300

added docker file

533abea

Update backend-ec2-deploy.yml

57546ff

Signed-off-by: Haroun Alarabi <[email protected]>

Update backend-ec2-deploy.yml

0dfdb0d

Signed-off-by: Haroun Alarabi <[email protected]>

Update backend-ec2-deploy.yml

0f21bb4

Signed-off-by: Haroun Alarabi <[email protected]>

updated fetch api

f5e4b79

Merge branch 'Level--300' of https://github.com/HarounAlarabi/Full-St…

595712c

…ack-Project-Assessment into Level--300

added terraform config

e25ba7d

Update backend-ec2-deploy.yml

49617c4

Signed-off-by: Haroun Alarabi <[email protected]>

Update backend-ec2-deploy.yml

11a7fb5

Signed-off-by: Haroun Alarabi <[email protected]>

Update VideosList.jsx

8daa84c

Signed-off-by: Haroun Alarabi <[email protected]>

Update Video.jsx

0547896

Signed-off-by: Haroun Alarabi <[email protected]>

Update VideosList.jsx

94b8243

Signed-off-by: Haroun Alarabi <[email protected]>

Update Video.jsx

ee88fa6

Signed-off-by: Haroun Alarabi <[email protected]>

Dedekind561 closed this Apr 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Glasgow 6 | Haroun Alarabi | Full-Stack-Project-Assessment | Level 300 #393

Glasgow 6 | Haroun Alarabi | Full-Stack-Project-Assessment | Level 300 #393

HarounAlarabi commented Sep 3, 2023 •

edited

Loading

Dedekind561 commented Sep 12, 2023

Dedekind561 commented Sep 16, 2023

Dedekind561 commented Sep 16, 2023

HarounAlarabi commented Sep 16, 2023

Dedekind561 left a comment

Dedekind561 Sep 16, 2023

Dedekind561 Sep 16, 2023

HarounAlarabi Sep 17, 2023

Dedekind561 Sep 16, 2023

HarounAlarabi Sep 17, 2023

Dedekind561 Sep 16, 2023

Dedekind561 Sep 16, 2023

HarounAlarabi Sep 17, 2023

Dedekind561 Sep 16, 2023

HarounAlarabi Sep 17, 2023

Dedekind561 Sep 16, 2023

Glasgow 6 | Haroun Alarabi | Full-Stack-Project-Assessment | Level 300 #393

Glasgow 6 | Haroun Alarabi | Full-Stack-Project-Assessment | Level 300 #393

Conversation

HarounAlarabi commented Sep 3, 2023 • edited Loading

Dedekind561 commented Sep 12, 2023

Dedekind561 commented Sep 16, 2023

Dedekind561 commented Sep 16, 2023

HarounAlarabi commented Sep 16, 2023

Dedekind561 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HarounAlarabi commented Sep 3, 2023 •

edited

Loading