London | 26-ITP-Sep | Shirin Panahian | Sprint 2 | Complete Sprint 2 Coursework by shirinpanahian · Pull Request #1545 · CodeYourFuture/Module-JavaScript-Fundamentals

shirinpanahian · 2026-09-19T20:25:08Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1039

Changelist

I solve and complete every 4 section and understand how write the java code and find the error.

netlify · 2026-09-19T20:25:13Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`7fa22d6`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6ab032634e62a9000806dca5
😎 Deploy Preview	https://deploy-preview-1545--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 99 (🔴 down 1 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

abdishakoor-dev

Good work on the interpret section. All five answers in 1-percentage-change.js are right, including the declarations, which people often get wrong.

A few things to fix:

1-key-exercises/3-paths.js line 16, see my comment.
1-key-exercises/4-random.js line 10, see my comment.
3-mandatory-interpret/2-time-format.js answer f), see my comment.
2-mandatory-errors/1.js line 6, see my comment.
Could you run Prettier on the files you have changed? Most of them are not formatted at the moment.

Add the Needs Review label again when you have pushed.

abdishakoor-dev · 2026-09-20T10:49:07Z

-const ext = ;
-
-// https://www.google.com/search?q=slice+mdn
+const dir = filePath.slice(0,`${lastSlashIndex}`-1);


Run this file and read the dir line carefully. It prints .../week-1/interpre, and the folder is called interpret. One character is being lost. What is the - 1 doing at the end of this line, and does slice need it?

The - 1 makes the slice stop one character too early, which removes the t from interpret. It isn’t needed. thank you for mention .

That's it, the dir line prints the full folder name now.

abdishakoor-dev · 2026-09-20T10:49:07Z

+//num represents a random whole number between 1 and 100,
+//first we calculate value inside parentheses(maximum - minimum +1) = 100 -1 + 1 =100 
+// math.random return number between 0 and 1
+// math.random() * 100 give us a integer number 


Have a look at this line again. Try running console.log(Math.random() * 100) a few times. Is what you get back an integer? If it were, what would be left for Math.floor to do on the next line?

Yeah I write wrong, Math.random() * 100 does not give us an integer. It gives us a decimal number between 0 and 100 for example 0.83488 *100 = 83.488. This is why we use Math.floor() . Math.floor(83.488) rounds the number down to 83. Then we add 1, giving us 84.

Yes, exactly that.

abdishakoor-dev · 2026-09-20T10:49:07Z

+// another name could be movieTime

 // f) Try experimenting with different values of movieLength. Will this code work for all values of movieLength? Explain your answer
+// This code works for normal positive number representing but for negative number and very big number it is not working  


Negative numbers are right. A very big number is fine though, try 999999 and see. Two things worth trying instead: 59, and a number with a decimal like 90.5. What does each one print, and would you show a time that way?

The code work for big number, I try 999999 and it return correct number. However, if movieLength = 90.5, it prints 0:1:30.5. This is not a good way to show a time because the seconds contain decimals. So the code works properly for whole numbers, but not for negative numbers and decimal numbers because the result can contain decimal values.

Good. 59 is worth a try too: it prints 0:0:59, which is the other thing that looks wrong.

abdishakoor-dev · 2026-09-20T10:49:07Z

+let age = 33;
 age = age + 1;
+console.log(`${age}`);
+//We should use let if we want to change the value.


Your fix is right. In 2.js, 3.js and 4.js you also wrote down the message node printed, which is what this section asks for. What did node say here before you changed const to let?

Before I changed const to let node show this error message: (Assignment to constant variable.)

That's the one.

abdishakoor-dev

All four sorted, and dropping the big-number claim in f) was the right call.

One thing left before I mark this Complete: Prettier still flags three files, 1-key-exercises/2-initials.js and both markdown files in 4-stretch-explore. You clearly ran it on the files you were editing, these are the ones that got missed.

Rather than chasing them file by file, turn on format on save. Then every file you touch is formatted when you hit save and this stops coming up in future PRs: https://github.com/CodeYourFuture/Module-JavaScript-Fundamentals/blob/main/practical_guide.md

There is also a note inline on 3-paths.js, not a blocker.

Add the Needs Review label again once you have pushed.

abdishakoor-dev · 2026-09-20T18:44:59Z

-const ext = ;
-
-// https://www.google.com/search?q=slice+mdn
+const dir = filePath.slice(0, `${lastSlashIndex}`);


The - 1 is gone and the folder name is complete now, good. Why the backticks around lastSlashIndex though? It is already a number, so this turns it into a string and slice converts it straight back.

remove unnecessary backtick

Backticks gone, and the line reads clearly now.

abdishakoor-dev

All fixed, marking this as complete, well done. Format on save will save you this round in every sprint from here.

shirinpanahian added 14 commits September 17, 2026 12:13

add dir and ext

8e8fb39

explain line 3

21470a9

find first letter

a9e44ee

explain how it working

59481d1

using comment

fda7c0d

change const to let

a6dbd79

change variable position

5bc72b3

change var type

516c24c

variable name error

01adbcc

answer questions

a52cfdb

answer all the question

71baeb7

understand and answer question

4e607b2

learn about console and objects

837636d

Complete sprint 2 coursework

373e8ae

shirinpanahian added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 19, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 19, 2026

This comment has been minimized.

Sign in to view

Remove unrelated prep files

cfee6b6

shirinpanahian added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 20, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 20, 2026

Remove prep files

ccb29be

shirinpanahian added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 20, 2026

abdishakoor-dev reviewed Sep 20, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 20, 2026

shirinpanahian added 2 commits September 20, 2026 17:59

fix the error

73b8e26

correct the wrong answer

7d41310

shirinpanahian added 2 commits September 20, 2026 19:16

changes answer

e765236

format documets

8c04eec

shirinpanahian added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 20, 2026

abdishakoor-dev reviewed Sep 20, 2026

View reviewed changes

abdishakoor-dev removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 20, 2026

Configure format on save and fix formatting

9663fde

shirinpanahian added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 20, 2026

remove unnecessary backticks

7fa22d6

shirinpanahian removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 20, 2026

abdishakoor-dev reviewed Sep 20, 2026

View reviewed changes

abdishakoor-dev added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 20, 2026

Uh oh!

Conversation

shirinpanahian commented Sep 19, 2026

Learners, PR Template

Task code

Changelist

Uh oh!

netlify Bot commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify Bot commented Sep 19, 2026 •

edited

Loading