Manchester | 26-ITP-Sep | Mathew Shaibu | Sprint 1 | Structuring and testing data - #1635
Open
MattCarolus10 wants to merge 11 commits into
Open
MattCarolus10 wants to merge 11 commits into
MattCarolus10 wants to merge 11 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
MattCarolus10
added
the
Needs Review
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
MattCarolus10
changed the title
MattCarolus10
added
the
Needs Review
cjyuan
reviewed
Oct 4, 2026
cjyuan
added
Reviewed
MattCarolus10
added
the
Needs Review
cjyuan
reviewed
Oct 4, 2026
| function formatAs12HourClock(time) { | ||
|
|
||
| const hours = Number(time.slice(0, 2)); | ||
| const minutes = time.slice(3); |
Contributor
There was a problem hiding this comment.
Note: The .slice() method supports negative indices, which count positions from the end of the string.
For example, str.slice(-3) returns the substring containing last three characters from str.
Author
There was a problem hiding this comment.
Is this an error that needs to be fixed, I thought negative values don't make a real time.
Contributor
There was a problem hiding this comment.
I think you misunderstood my comment.
| return `${time} am`; | ||
| return `${time}am`; | ||
| } | ||
| console.log(formatAs12HourClock("14:00")); |
Contributor
There was a problem hiding this comment.
Note: To keep the codebase clean, best practice is to ensure code submitted to a PR free of unused code (including debugging code).
Author
There was a problem hiding this comment.
I have removed the unwanted line of codes. Thank you
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1197
Changelist